Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for all functions/flow of leaderboard #88

Open
coxmars opened this issue Nov 19, 2024 · 9 comments
Open

Create unit tests for all functions/flow of leaderboard #88

coxmars opened this issue Nov 19, 2024 · 9 comments
Assignees
Labels
external-contributor Available for external contributors good first issue Good for newcomers ODHack10

Comments

@coxmars
Copy link
Contributor

coxmars commented Nov 19, 2024

Start this issue once we have merged the model and functions implemented in the leaderboard: #28

You can review the current tests and try to add edge cases as a plus.

However, the idea/scope for this task is to implement the system/flow tests for the functions created.

  • Use this PR as an example of what we want to have: Add tests for tournament_system #101
  • So, you need to create a new file like leaderboard.cairo in systems directory.
  • Add the flow according with the functions and logic in leaderboard.cairo and after that validate all it's working as expected running sozo build/sozo test.
  • When it's done add the proof/output of those commands as an image in your PR.

Follow the Contributions Guidelines and PR guidelines/example etc.
If you need help just ask me here in a comment or ping me in Telegram in the group channel for external contributors.
Thanks for your time, please send a comment with your approach/solution, be creative and use a technical explanation and avoid ChatGPT or AI comments.

@coxmars coxmars added good first issue Good for newcomers external-contributor Available for external contributors ODHack10 labels Nov 19, 2024
@josephchimebuka
Copy link

HelloI am Joseph I am a frontend developer and blockchain developer and I am also an active contributor here on only dust here is my profile https://app.onlydust.com/u/josephchimebuka.
I'd like to handle this task.

@enyinnaya1234
Copy link

I am a fullstack developer with experience providing solutions. i believe i can provide solution to this issue. can i take it on?

@manlikeHB
Copy link

Hi, I am a Cairo developer with great experience writing robust test coverage for smart contracts. Let me work on this.

@ShantelPeters
Copy link

May I handle this issue?

@Michaelkingsdev
Copy link

Could I take a shot at this?

@KevinMB0220
Copy link
Contributor

Hi, my name is Kevin from Dojo Coding. I have experience working with Cairo as I am currently developing a game, focusing on the backend. I would address this issue by following the proper standards and reviewing the mentioned repositories to guide my approach to resolving it.
To start, I would carefully review issue #28 and PR #39 to understand the functions and model implemented in the leaderboard. Then, I would design comprehensive unit tests that cover both standard and edge cases, ensuring the leaderboard correctly handles the dynamic addition and updating of elements.

@JoE11-y
Copy link

JoE11-y commented Nov 21, 2024

I’d like to resolve this.

@coxmars
Copy link
Contributor Author

coxmars commented Nov 21, 2024

Hi, my name is Kevin from Dojo Coding. I have experience working with Cairo as I am currently developing a game, focusing on the backend. I would address this issue by following the proper standards and reviewing the mentioned repositories to guide my approach to resolving it. To start, I would carefully review issue #28 and PR #39 to understand the functions and model implemented in the leaderboard. Then, I would design comprehensive unit tests that cover both standard and edge cases, ensuring the leaderboard correctly handles the dynamic addition and updating of elements.

@KevinMB0220 assigned, if you need help or guidance just ask me 🫡

@KevinMB0220
Copy link
Contributor

Hi, my name is Kevin from Dojo Coding. I have experience working with Cairo as I am currently developing a game, focusing on the backend. I would address this issue by following the proper standards and reviewing the mentioned repositories to guide my approach to resolving it. To start, I would carefully review issue #28 and PR #39 to understand the functions and model implemented in the leaderboard. Then, I would design comprehensive unit tests that cover both standard and edge cases, ensuring the leaderboard correctly handles the dynamic addition and updating of elements.

@KevinMB0220 assigned, if you need help or guidance just ask me 🫡

Thanks sir🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Available for external contributors good first issue Good for newcomers ODHack10
Projects
Status: TODO 🥷
Development

No branches or pull requests

8 participants