Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the season PoC model and functions #90

Open
coxmars opened this issue Nov 19, 2024 · 6 comments
Open

Add unit tests for the season PoC model and functions #90

coxmars opened this issue Nov 19, 2024 · 6 comments
Assignees
Labels
external-contributor Available for external contributors good first issue Good for newcomers ODHack10

Comments

@coxmars
Copy link
Contributor

coxmars commented Nov 19, 2024

Start this issue once we have merged the model and functions implemented in the season: #89

You can review the current tests and try to add edge cases as a plus.

  • Invalid inputs (e.g., non-existent IDs, overlapping dates).
  • Handling of empty dynamic arrays like active_players.

However, the idea/scope for this task is to implement the system/flow tests for the functions created.

  • Use this PR as an example of what we want to have: Add tests for tournament_system #101
  • So, you need to create a new file like season.cairo in systems directory.
  • Add the flow according with the functions and logic in season.cairo and after that validate all it's working as expected running sozo build/sozo test.
  • When it's done add the proof/output of those commands as an image in your PR.

Follow the Contributions Guidelines and PR guidelines/example etc.
Include clear comments to explain the test logic and why specific scenarios are covered.

If you need help just ask me here in a comment or ping me on Telegram in the group channel for external contributors.

Thanks for your time, please send a comment with your approach/solution, be creative and use a technical explanation and avoid ChatGPT or AI comments.

@coxmars coxmars added good first issue Good for newcomers external-contributor Available for external contributors ODHack10 labels Nov 19, 2024
@coxmars coxmars changed the title Add unit tests for the season PoC model and functions. Add unit tests for the season PoC model and functions Nov 20, 2024
@PabloVillaplana
Copy link

Hi, I'm Juan Pablo Villaplana from Dojo Coding, I'd like to contribute to that ByteBeats issue

I'd like to contribute to the project, to be honest, in order to practice more with Cairo, I can cover several unit tests for those methods as the description says. I think the ticket description is pretty clear with the objectives that we want to achieve

@CollinsC1O
Copy link

I’d like to work on this.

@ShantelPeters
Copy link

Let me try this one!

@MrRoudyk
Copy link

May I try my hand at this?

@coxmars
Copy link
Contributor Author

coxmars commented Nov 21, 2024

Hi, I'm Juan Pablo Villaplana from Dojo Coding, I'd like to contribute to that ByteBeats issue

I'd like to contribute to the project, to be honest, in order to practice more with Cairo, I can cover several unit tests for those methods as the description says. I think the ticket description is pretty clear with the objectives that we want to achieve

Go ahead sir, if you need more guidance or help don't hesitate to contact me 🫡

@JoE11-y
Copy link

JoE11-y commented Nov 21, 2024

Can I start working on this?

This was referenced Nov 30, 2024
PabloVillaplana added a commit to PabloVillaplana/ByteBeastsBackend that referenced this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Available for external contributors good first issue Good for newcomers ODHack10
Projects
Status: TODO 🥷
Development

No branches or pull requests

6 participants