Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Slopes and Intercepts for RobReg (Expressions) and Interpretation regressions #617

Open
AllenKennedy opened this issue May 4, 2021 · 6 comments
Assignees

Comments

@AllenKennedy
Copy link

AllenKennedy commented May 4, 2021

Below is ExpoTh peek results, and a regression of the same two parameters under Interpretations. There is a difference in the calculated Slope and Intercept of these two regressions. I tested this when both parameters are highly correlated and the slope is close to 1.0, such as Pb/Th vs Pb/ThO and there still is a difference in outcomes. I assume the regression equations are different and we need an explanation for the users.

Screen Shot 2021-05-04 at 3 55 25 pm

Screen Shot 2021-05-04 at 3 54 57 pm

@bowring
Copy link
Member

bowring commented May 4, 2021

This is another instance of the random number generator problem that we are seeking to resolve. In addition the 2-D regression shown in the "plot any two" is generated using Noah McLean's (@noahmclean) algorithms and not using RobReg. You have clearly identified a problem we need to resolve.

@bowring
Copy link
Member

bowring commented May 4, 2021

I experimented by setting the uncertainties to zero prior to using McLean Regression in plot-any-two and get very similar results to RobReg. So it seems that in addition to solving the RobReg issue, we need to decide whether plot-any-two regressions should use McLean or RobReg or both (with a choice). Thanks to @AllenKennedy for your continued testing!

@NicoleRayner
Copy link
Contributor

So "plot any two" is a McLean regression? I think that we should definitely include a RobReg as this is what folks are going to assume is the same as the Expo expression.

Relatedly - and this was the case in squid2.5, you can't exclude analyses from RobReg (manually or auto reject) used to calculate Expo - you can exclude things from the weighted mean of the calib constant, but not the regression.

This can be problematic when you have a RM analysis with a major analytical problem (like a duo flame out) but now in squid3 at least it is easy to remove this analysis from processing in the data audit (or manage samples) windows. I don't think we need to provide this functionality here but a warning to people who see the weighted mean rejects excluded in their plot LnUO/U vs LnPb/U and expect that this will align with their RobReg in expressions.

@noahmclean
Copy link

Can I be of any help? What's RobReg? Is McLean Regression (in 2D, same as York and many others) producing different outputs?

@bowring
Copy link
Member

bowring commented May 8, 2021

@noahmclean - RobReg is the Isoplot version of robust regression that does not include uncertainties and does include the use of random numbers to perturb the slope as discussed in issue #615. There are two basic issues - 1) should RobReg even use random numbers and if so, should it use the same series each time to guarantee reproducibility? and 2) provide both RobReg and McLean regression for users of plot-any2.

@noahmclean
Copy link

noahmclean commented May 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants