Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the ES index after each index/bulk call, so results are available for search right after #13

Open
jblom opened this issue Sep 2, 2022 · 3 comments
Assignees

Comments

@jblom
Copy link
Member

jblom commented Sep 2, 2022

After posting new documents to DANE and subsequently calling DANE to add new Tasks, the index is not always quick enough to refresh, so the Tasks cannot be added (because the docs are not available yet)

To avoid this race condition. The bulk index call needs to be extended with a refresh=True.

@jblom
Copy link
Member Author

jblom commented Sep 5, 2022

Update: so in order for the fix to be picked up, the DANE-server needs to use the new DANE code (with the extra refresh param). Since the DANE-server was never properly upgraded (ES7 client, latest DANE version, linting, code formatting etc) this is a nice opportunity to do so.

This PR shows the current progress. The basic upgrade and bugfix are ready to be tested in the ASR pipeline. CLARIAH/DANE-server#4

@jblom
Copy link
Member Author

jblom commented Sep 5, 2022

Update: the fix to DANE seems to work in the DANE-server API

I've tested it, using the improved main.py of the dane-workflows library

@jblom
Copy link
Member Author

jblom commented Sep 5, 2022

@KleinRana @mwigham or @wmelder the new DANE-server is deployed in the cluster and seems to work fine for me. If you could test with a fresh workflow? When it properly works, please close this issue.

In any case: please report your results in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant