Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP Server: allow full 65 characters #32

Open
cyroxx opened this issue Jan 3, 2020 · 4 comments
Open

TCP Server: allow full 65 characters #32

cyroxx opened this issue Jan 3, 2020 · 4 comments

Comments

@cyroxx
Copy link
Member

cyroxx commented Jan 3, 2020

We currently enforce a line-wrap after 65 characters, whatever the characters are. So if somebody sends us lines of 65 characters + newline, we actually get 2 newlines: the one that is enforced and the one from the incoming request.

We should skip enforcing line wrap in that case since the client already sends us the newline.

@ArchibaldBienetre
Copy link

ArchibaldBienetre commented Jan 18, 2020

There's a similar Issue request by @sirexeclp :
#73 + follow-up #74

@cyroxx
Copy link
Member Author

cyroxx commented Jan 18, 2020

btw, the default number of characters is 78. The 65 characters was just a setting that i used at some point for demonstration purposes when the device is unattended.
The enforced line-wrap (see above) still needs to be eliminated, though.

@sirexeclp
Copy link

see http://hc-ddr.hucki.net/wiki/doku.php/z9001/erweiterungen/s3004

Code Funktion Bemerkung
80H Randlöser Rand lösen
8FH Randlöser ON (extern) Rand rechts öffnen (*); Extremer Randlöser. Die Randeinstellung wird bis zum Eintreffen von SETRD nicht mehr berücksichtigt.

@sirexeclp
Copy link

also i've copy pasted the table into our wiki, so we can add our own comments, to make things clearer
and ofc. translate it
https://github.com/Chaostreff-Potsdam/erika3004/wiki/Control-characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants