Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for
missing information.
or merged features/bug fixes.
Pull Request Information
Check and fill in the blanks for all that apply:
menu
module of the JDA-Utilities library.______
.Description
This PR implements a central PaginationHandler class which as the name suggests will be used to handle the pagination of the various menus in a more general way.
I wasn't too happy with my previous attempt (#29) so I decided to redo it. The main difference is, that this system is now in a completely separate package called
pw.chew.jdachewtils.menu
. This was the easiest way for me to not have major breaking changes that could frustrate the end user when updating.I also made a central Builder interface instead of an abstract class... Not to sure about that one tbh, but it feels cleaner than the abstract stuff.
To-Do
ButtonMenuCannot be supported due to it allowing multiple buttons/reactionsOrderedMenuNot doable due to its more complex handling of thingsSelectionDialogSeems a bit too complicated for the simple PaginationHandler to.. handle