Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume feature #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Inglebard
Copy link

Hi,
I don't know if it's the best way to do that, but i think the possibility to change the volume can be interesting.

@Stealthii
Copy link
Contributor

This is similar to the volume work I did on the original PiFM C code. I would suggest squashing these commits into a single commit and giving it a better description.

I have tested this code and it works as expected.

@ChristopheJacquet
Copy link
Owner

Hi,

Okay to add the feature. Thanks for the patch, however it decreases the amplitude of the whole MPX signal, i.e. not only of the audio component, but also of the RDS component and pilot tone. I suppose this can be a problem. I'm going to look into that.

@Inglebard
Copy link
Author

Hi,
Be careful i have not a lot of skill in C/C++ programming.
Like Stealthii said, I found a note on original Pifm code and i need it in PifmRDS (to much volume diffence between original radio station and PifmRDS), so i tried to apply and update for PifmRDS.
The "patch" may be not correct/not optimise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants