Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParquetWriter Nullable Types #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaxZ2033
Copy link

fixes #314
ParquetWriter assigns type nullable instead of type string to nullables.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code snippet, while functional, can be optimized for readability and maintainability. The repeated typeof(string) returns suggest a potential refactor to reduce redundancy. Grouping these similar conditions together or using a switch-case statement could enhance clarity. Additionally, incorporating comments to explain the rationale behind each condition would benefit future developers. Ensuring consistent formatting and adding a final else clause to handle unexpected types would also improve robustness. Overall, the code achieves its purpose but could be streamlined for better efficiency and comprehension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Csv to Parquet - Nullable types
2 participants