Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid dates reported as missing required fields #166

Open
inghamn opened this issue May 4, 2018 · 0 comments
Open

Invalid dates reported as missing required fields #166

inghamn opened this issue May 4, 2018 · 0 comments

Comments

@inghamn
Copy link
Member

inghamn commented May 4, 2018

If you type an invalid date into the form, it gets wiped and the form reloads with a "missingRequiredFields" error, instead of an "invalidDate" error.

This is because the controller throws away any invalid dates during input parsing. Actual form validation doesn't occur until during save(). But by then, whatever garbage the user typed is long gone.
inghamn added a commit that referenced this issue May 4, 2018
@inghamn
Event Update: throw an exception with invalidDates
8872931 
If dates cannot be parsed, throw an exception.  We'll still
lose whatever the user typed, but at least the error will be
more accurate.

Updates #166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inghamn