Implement and test vertical mass borrowing limiters #2084
+508
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/MassBorrowerFixer
branch
from
e75025f to
13f55b2
Compare
|
This does seem to work in that it removes negative tracer values, and seems to preserve mass (both of which are unit-tested cc @tapios): On a single column: @test 0 ≤ minimum(q)
@test isapprox(sum(q), sum_q_init; atol = 0.00000000001)
@test isapprox(sum(q), sum_q_init; rtol = 0.01)On a full cubed sphere: @test 0 ≤ minimum(q)
@test isapprox(sum(q), sum_q_init; atol = 0.013)
@test isapprox(sum(q), sum_q_init; rtol = 0.01)I think But, the transport/wavespeed doesn't look great: 
I guess that's a bit orthogonal, though? |
charleskawczynski
force-pushed
the
ck/MassBorrowerFixer
branch
2 times, most recently
from
21528d7 to
ec53007
Compare
|
pdel is a hydrostatic approximation of rho*dz, so we need to update this. Also, the mass conservation test at the end should be rho*q instead. |
tapios
requested changes
Nov 20, 2024
|
And let's visualize how this looks on the sphere. |
charleskawczynski
force-pushed
the
ck/MassBorrowerFixer
branch
2 times, most recently
from
1278c47 to
bae0e8e
Compare
Update src/Limiters/vertical_mass_borrowing_limiter.jl Co-authored-by: Tapio Schneider <[email protected]> Update src/Limiters/vertical_mass_borrowing_limiter.jl Co-authored-by: Tapio Schneider <[email protected]> Update src/Limiters/vertical_mass_borrowing_limiter.jl Co-authored-by: Tapio Schneider <[email protected]> Use density-dz for pressure thickness
charleskawczynski
force-pushed
the
ck/MassBorrowerFixer
branch
from
7082d56 to
e304c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. This PR implements vertical mass borrowing limiters.
Closes #2083.
Todo:
q_minbe computed? I thinkq_minis actually just prescribed.pdelthe correct interpretation? I think that this is justdzρq?