Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CenterCell should be the default staggering in CommonSpaces #2101

Open
Sbozzolo opened this issue Dec 14, 2024 · 0 comments
Open

CenterCell should be the default staggering in CommonSpaces #2101

Sbozzolo opened this issue Dec 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sbozzolo
Copy link
Member

I think that assuming a center staggering for CommonSpaces is a reasonable default, and it would help creating spaces easier.
For instance, the example

using ClimaCore.CommonSpaces
space = ColumnSpace(;
    z_elem = 10,
    z_min = 0,
    z_max = 10,
    staggering = Grids.CellCenter()
)

does not work because Grids is not imported. Importing Grids seems a little excessive when the module is only needed to set up the space.

Also, I think it would be good to have a function to go from center to face space and viceversa.

@Sbozzolo Sbozzolo added the enhancement New feature or request label Dec 14, 2024
@Sbozzolo Sbozzolo self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant