Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non required fields appear as required #369

Closed
poonam279 opened this issue Sep 11, 2024 · 2 comments · Fixed by #376
Closed

Non required fields appear as required #369

poonam279 opened this issue Sep 11, 2024 · 2 comments · Fixed by #376
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.

Comments

@poonam279
Copy link

Description

A user reported that non-required fields appear as required. We have already fixed this issue here: #316, but there is a new finding. The issue occurs if a required field is added before the non-required field.

Step-by-step reproduction instructions

  1. Create a meta group and add a required field first
  2. Now add a non-required field
  3. Attach it to a product
  4. Go to the product and don't fill in those not required fields, then try to add to cart

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot on 2024-09-11 at 22-54-30
Screenshot 2024-09-11 at 10 55 04 PM

HS Ticket: https://secure.helpscout.net/conversation/2702498320/433263?folderId=212385

Environment info

No response

Is the issue you are reporting a regression

No

@poonam279 poonam279 added the bug This label could be used to identify issues that are caused by a defect in the product. label Sep 11, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Sep 11, 2024
@girishpanchal30 girishpanchal30 linked a pull request Sep 13, 2024 that will close this issue
6 tasks
@girishpanchal30
Copy link
Contributor

I've reviewed this issue and fixed it here - #376

@poonam279
Copy link
Author

@girishpanchal30 I have checked and the issue is fixed.

@selul selul closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants