Commit number 234: Cannot locate type MwAttackOrderPowerInfo

[fusion809]

Hi,

On Arch Linux commit 234 (f0fdfb8) gives the build error:

CSC mods/d2k/OpenRA.Mods.D2k.dll
CSC OpenRA.Utility.exe
CSC OpenRA.Server.exe
make[1]: Leaving directory '/data/GitHub/others/Medieval-Warfare/engine'
Traits/Activites/PreyBuildActiviy.cs(56,56): error CS1061: 'WithHarvestAnimation' does not contain a definition for 'ChangeNot' and no extension method 'ChangeNot' accepting a first argument of type 'WithHarvestAnimation' could be found (are you missing a using directive or an assembly reference?)
Traits/Activites/PreyBuildActiviy.cs(108,59): error CS1061: 'WithHarvestAnimation' does not contain a definition for 'ChangeNot' and no extension method 'ChangeNot' accepting a first argument of type 'WithHarvestAnimation' could be found (are you missing a using directive or an assembly reference?)

likewise, after running it with ./launch-game.sh, or launching an AppImage built by running packaging/linux/buildpackage.sh, I get the exception:

OpenRA engine version {DEV_VERSION}
Medieval Warfare mod version release-20180218
Date: 2018-12-29 06:13:50Z
Operating System: Linux (Unix 4.20.0.1)
Runtime Version: Mono 5.16.0 (makepkg/bb3ae37d71a Sat Dec  8 13:21:35 CET 2018) CLR 4.0.30319.42000
Exception of type `System.AggregateException`: One or more errors occurred.
Inner
  Exception of type `System.InvalidOperationException`: Cannot locate type: MwAttackOrderPowerInfo
    at OpenRA.ObjectCreator+<>c.<.cctor>b__20_0 (System.String s) [0x00015] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.ObjectCreator.CreateObject[T] (System.String className, System.Collections.Generic.Dictionary`2[TKey,TValue] args) [0x0001a] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.ObjectCreator.CreateObject[T] (System.String className) [0x00008] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.ActorInfo.LoadTraitInfo (OpenRA.ObjectCreator creator, System.String traitName, OpenRA.MiniYaml my) [0x00042] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.ActorInfo..ctor (OpenRA.ObjectCreator creator, System.String name, OpenRA.MiniYaml node) [0x00058] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Ruleset+<>c__DisplayClass12_0.<LoadDefaults>b__1 (OpenRA.MiniYamlNode k) [0x00016] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Exts.ToDictionaryWithConflictLog[TSource,TKey,TElement] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] keySelector, System.Func`2[T,TResult] elementSelector, System.String debugName, System.Func`2[T,TResult] logKey, System.Func`2[T,TResult] logValue) [0x00091] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Ruleset.MergeOrDefault[T] (System.String name, OpenRA.FileSystem.IReadOnlyFileSystem fileSystem, System.Collections.Generic.IEnumerable`1[T] files, OpenRA.MiniYaml additional, OpenRA.IReadOnlyDictionary`2[TKey,TValue] defaults, System.Func`2[T,TResult] makeObject, System.Func`2[T,TResult] filterNode) [0x00080] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Ruleset+<>c__DisplayClass12_0.<LoadDefaults>b__0 () [0x00001] in <5e78c67f896f462780317e075f01a099>:0 
  at System.Threading.Tasks.Task.InnerInvoke () [0x0000f] in <eabff256da0b4c4db432852f93333375>:0 
  at System.Threading.Tasks.Task.Execute () [0x00000] in <eabff256da0b4c4db432852f93333375>:0 
  at System.Threading.Tasks.Task.ThrowIfExceptional (System.Boolean includeTaskCanceledExceptions) [0x00011] in <eabff256da0b4c4db432852f93333375>:0 
  at System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout, System.Threading.CancellationToken cancellationToken) [0x00043] in <eabff256da0b4c4db432852f93333375>:0 
  at System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout) [0x00000] in <eabff256da0b4c4db432852f93333375>:0 
  at OpenRA.Ruleset.LoadDefaults (OpenRA.ModData modData) [0x0007c] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.ModData.<.ctor>b__30_3 () [0x00000] in <5e78c67f896f462780317e075f01a099>:0 
  at System.Lazy`1[T].CreateValue () [0x00060] in <eabff256da0b4c4db432852f93333375>:0 
--- End of stack trace from previous location where exception was thrown ---

  at System.Lazy`1[T].get_Value () [0x00020] in <eabff256da0b4c4db432852f93333375>:0 
  at OpenRA.ModData.get_DefaultRules () [0x00001] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Ruleset.LoadDefaultsForTileSet (OpenRA.ModData modData, System.String tileSet) [0x00001] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Map.PostInit () [0x00080] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Map..ctor (OpenRA.ModData modData, OpenRA.FileSystem.IReadOnlyPackage package) [0x00438] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.ModData.PrepareMap (System.String uid) [0x0006e] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Game.StartGame (System.String mapUID, OpenRA.WorldType type) [0x0003f] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Game.LoadShellMap () [0x00018] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Mods.Common.LoadScreens.BlankLoadScreen.StartGame (OpenRA.Arguments args) [0x001ac] in <d833794afec44196b5f1d36fc71bf97d>:0 
  at OpenRA.Game.InitializeMod (System.String mod, OpenRA.Arguments args) [0x003e1] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Game.Initialize (OpenRA.Arguments args) [0x004d8] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Game.InitializeAndRun (System.String[] args) [0x00007] in <5e78c67f896f462780317e075f01a099>:0 
  at OpenRA.Program.Main (System.String[] args) [0x0004e] in <5e78c67f896f462780317e075f01a099>:0 

. The full logs of this exception are here: mw-20181229-f0fdfb8df3bdfe34cbc56207bf1561cc1493268d-no-234-logs.zip. The test suite gives this error (which is pretty predictable, even for someone that isn't a C# programmer like myself): https://gist.github.com/6d4100f51df2e9b10bb2d6cc8fb5c2b9.

Thanks for your time,
Brenton

[CombinE88]

is only a quicksafe non fixed bugs, will work on that. thanks