Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SignKey instead of KeyPair in Haskell signing #501

Open
annenkov opened this issue Jan 17, 2024 · 0 comments
Open

Use SignKey instead of KeyPair in Haskell signing #501

annenkov opened this issue Jan 17, 2024 · 0 comments
Labels
good first issue Good for newcomers [Type] Task An additional feature or improvement.

Comments

@annenkov
Copy link
Contributor

Task description

The function signatures BlockSignature.sign and SignatureScheme.sign have KeyPair as a parameter. The interface of the ed25519-dalek library is different in v2: the verification key is not part of the API. For that reason, it doesn't make sense to pass KeyPair, since it's sufficient to pass SignKey .

These changes need to be propagated to concordium-node and concordium-client
@annenkov annenkov added the [Type] Task An additional feature or improvement. label Jan 17, 2024
@annenkov annenkov mentioned this issue Jan 17, 2024
Merged
5 tasks
@abizjak abizjak added the good first issue Good for newcomers label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers [Type] Task An additional feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abizjak @annenkov