Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common-sdk v9] Remove dependency on WASM from GRPC client #344

Open
soerenbf opened this issue Apr 2, 2024 · 0 comments
Open

[common-sdk v9] Remove dependency on WASM from GRPC client #344

soerenbf opened this issue Apr 2, 2024 · 0 comments
Labels
[Project] js-sdk [Size] Small [Type] Change Request Some visible functionality should be change.

Comments

@soerenbf
Copy link
Collaborator

soerenbf commented Apr 2, 2024

Description
As the concordium browser wallet exposes a GRPC client from the SDK and injects the code for it into applications, it would be good to not include WASM code as this takes a heavy toll on the browser to include.

I'm fairly certain this dependency stems from this line:

const payloadHex = serializeCredentialDeploymentPayload(
but we need to make sure no other references to WASM code are present.

Versions

  • Software Version 9.5.3
@soerenbf soerenbf added the [Type] Change Request Some visible functionality should be change. label Apr 2, 2024
@mh-concordium mh-concordium added the [Res] works as designed The functionality is as intended. label May 13, 2024 — with Linear
@mh-concordium mh-concordium removed the [Res] works as designed The functionality is as intended. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] js-sdk [Size] Small [Type] Change Request Some visible functionality should be change.
Projects
None yet
Development

No branches or pull requests

2 participants