Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once minimum Rust version is 1.76 remove use of async_trait #152

Open
abizjak opened this issue Feb 13, 2024 · 0 comments
Open

Once minimum Rust version is 1.76 remove use of async_trait #152

abizjak opened this issue Feb 13, 2024 · 0 comments
Labels
[Type] Change Request Some visible functionality should be change.

Comments

@abizjak
Copy link
Contributor

abizjak commented Feb 13, 2024

Currently in a few places we define traits with async methods.

In the past it was necessary to use the async_trait macro for this, which is not very ergonomic since when a user wants to implement the trait they can't use rust-analyzer autocompletion to "implement missing members" easily. It generates the wrong placeholders.

In Rust 1.76 there is sufficient support for async methods in traits so once we set MSRV to that we should revise the use of async_trait macro.

@abizjak abizjak added the [Type] Change Request Some visible functionality should be change. label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Change Request Some visible functionality should be change.
Projects
None yet
Development

No branches or pull requests

1 participant