-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GraphFrame
variant for comment nodes
#463
Labels
kind/enhancement
New feature or request
Milestone
Comments
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Jun 30, 2024
6 tasks
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Jun 30, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Jun 30, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Jun 30, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Jul 13, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Jul 13, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Jul 13, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Aug 15, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Aug 15, 2024
Naros
added a commit
to Naros/godot-orchestrator
that referenced
this issue
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Godot 4.3 introduced a new graph element called
GraphFrame
, which is ideal for comment nodes. For Orchestrator 2.1, we should aim to move to usingGraphFrame
rather than our custom implementation.Implementation ideas
One way to handle the auto-upgrade would be to introduce a new BitField in the Orchestration. When moving to 2.1, the flag would be false, signaling that the editor should automatically link any graph node that overlaps with a frame. Once this step is done, the flag will be set to true so that the auto-link will not happen.
Comment nodes in 2.1 will need to store their linked nodes.
This attribute/property would only be serializable in 2.1, not 2.0.
If an Orchestration that had been saved with 2.1 is opened with 2.0 and re-saved, then the flag and linked nodes to frames will be lost; however, when re-opening the Orchestration with 2.1, the auto-link phase will refire, and nothing will be lost.
The text was updated successfully, but these errors were encountered: