Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Editor Undo/Redo operations #58

Open
Naros opened this issue Jan 5, 2024 · 2 comments · May be fixed by #526
Open

Support Editor Undo/Redo operations #58

Naros opened this issue Jan 5, 2024 · 2 comments · May be fixed by #526
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/enhancement New feature or request
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Jan 5, 2024

Description

To improve the user experience, the plug-in should support complete undo/redo operations.

Implementation ideas

No response
@Naros Naros added the kind/enhancement New feature or request label Jan 5, 2024
@Naros Naros added this to the 2.0 milestone Jan 5, 2024
@VladimirLevadnij
Copy link

This is a good idea, because at the moment, when I want to undo the last action, I automatically press CTRL+Z on the keyboard, no cancellation occurs on the visual script canvas, but Godot intercepts this command and makes the cancellation in another place, for example, in node configurations. This can go unnoticed and break the application.

@Naros Naros modified the milestones: 2.0, 2.1 Mar 30, 2024
@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Mar 30, 2024
@Naros
Copy link
Member Author

Naros commented Jul 14, 2024 •
edited
Loading

Logical Operations

  • Place new node - complex step, currently cannot be undone. ⚠️
  • Delete node - complex step, currently cannot be undone. ⚠️
  • Move node ☑️
  • Change pin default value ☑️
  • Connect/Disconnect pins ☑️
  • Component Changes
    • Create Graph/Function/Variable/Signal - complex step, currently cannot be undone. ⚠️
    • Delete Graph/Function/Variable/Signal - complex step, currently cannot be undone. ⚠️
    • Rename Graph/Function/Variable/Signal - ☑️
  • Cut/Duplicate Node - complex step, currently cannot be undone. ⚠️
  • Collapse/Expand - complex step, currently cannot be undone. ⚠️
  • Add/Remove pins on editable pin nodes - complex step, currently cannot be undone. ⚠️
  • Change Base Type (seems to be handled by Inspector) ☑️
  • Export Variable Toggle (Component Panel - Inspector handled by Godot) ☑️

The current API for certain actions is insufficient to support undo/redo operations, which are identified with the ⚠️ icon. In these cases, we will continue to look into refactors to make this possible, but may be omitted in the initial undo/redo pass.

Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 14, 2024
@Naros
CraterCrashGH-58 Initial support for undo/redo
ed4648e 
* Moving nodes
* Changing pin default values
* Connect and disconnect pins
* Renaming components (graphs, functions, variables, signals)
* Changing the Orchestration base type
* Export variable toggle in component panel
* Inspector changes already supported by Godot
@Naros Naros linked a pull request Jul 14, 2024 that will close this issue
Open
@Naros Naros modified the milestones: 2.1, 2.2 Jul 21, 2024
@Naros Naros mentioned this issue Aug 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/enhancement New feature or request
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-58 Initial support for undo/redo Naros/godot-orchestrator
2 participants
@Naros @VladimirLevadnij