-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added wait timeout to server start #918
base: master
Are you sure you want to change the base?
Conversation
I quickly tested it and it worked fine for me 🥳 The only downside i see is that we still lose the information why it failed |
Isn't that logged? |
hmm, I see, the timeout can have different reasons and in addition the Acceptor and endpoint are created in the constructor of the server. Would make this ticket bigger. |
Did you written your answer on purpose as edit on my comment? 😆 I mean i think this fix already brings value the way it is now but to fully fix it it probably should log the errors that happen. |
|
f872423
to
21ee6b7
Compare
21ee6b7
to
d566cb9
Compare
Invalid address strings are now logged, so mission complete. :) |
I found another case 🙈 where if the port is already used we also just see a timeout:
But im not sure if we can check for that, and this version is already way better than before 🥳 |
This has to be handled inside of the server, I would propose to handle in a different issue - or maybe there are already some for this. |
… logged now, server runs into timeout in that case added testcase for invalid address
f66f065
to
e31486d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran some manual tests against this latest version which worked fine for me
[100%] Built target radiopi
(2024-11-26 11:49:19) [INFO ] Playing some music
(2024-11-26 11:49:19) [ERROR ] Invalid argument - Can not create valid ip address from string: "0.0.0.a"
No description provided.