Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers have a lot of shadowing of variables. #919

Open
mjmessina opened this issue Oct 15, 2024 · 0 comments
Open

Headers have a lot of shadowing of variables. #919

mjmessina opened this issue Oct 15, 2024 · 0 comments
Labels
feature Code based project improvement

Comments

@mjmessina
Copy link

Headers have a lot of shadowing of variables.

Would be nice if you cleaned up some of the shadowing. if you compile with -Wshadow you can see all the warnings.
Our projects compile with warnings as errors. To get around it:

#pragma GCC diagnostic ignored "-Wshadow"
#include "crow.h"
#pragma GCC diagnostic pop
@gittiver gittiver added the feature Code based project improvement label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Code based project improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gittiver @mjmessina