Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update conda-lock version after updates #15

Closed
JessicaS11 opened this issue Oct 17, 2022 · 4 comments · May be fixed by #14
Closed

update conda-lock version after updates #15

JessicaS11 opened this issue Oct 17, 2022 · 4 comments · May be fixed by #14

Comments

@JessicaS11
Copy link
Contributor

The most recent (v1.1.3) version of conda-lock includes a switch (that happened in v1.1.0 with PR#89) from relative to absolute paths. As a result, whenever someone new updates the conda lock files, their local dir path is added to the lockfile source list (and other users get a warning for every path listed that's not on their local machine). It looks like a fix is in the works, so I reverted to v1.0.5 until this update is implemented. @weiji14, please let me know if this will be an issue for anything you added and we can deal with the warnings until the update lets us specify relative paths.
@weiji14
Copy link
Member

weiji14 commented Oct 17, 2022

Thanks Jessica, I was going to switch to a generic /home/jovyan path (see 57e6b3fcf9bd1f91b8bd31d31150a3d10bd9d917), but even better if conda-lock fixes it upstream! Feel free to mess around with the lockfiles if needed.

@weiji14 weiji14 transferred this issue from CryoInTheCloud/CryoCloudWebsite Nov 29, 2022
weiji14 added a commit that referenced this issue Nov 29, 2022
@weiji14
Pin to conda-lock 1.0.5 to keep relative paths
e609d9c 
See #15.
@weiji14 weiji14 mentioned this issue Nov 29, 2022
Draft
4 tasks
@tsnow03 tsnow03 moved this to 📋 Backlog in March 2023 Event Feb 2, 2023
@tsnow03 tsnow03 moved this from 📋 Backlog to 🏗 In progress in March 2023 Event Feb 8, 2023
@JessicaS11 JessicaS11 mentioned this issue Mar 1, 2023
Open
@JessicaS11
Copy link
Contributor Author

Conda-lock has officially closed this issue as fixed (not sure if it's yet released): conda/conda-lock#229

@weiji14
Copy link
Member

weiji14 commented May 28, 2023

Conda-lock 2.0.0 was released which also included conda/conda-lock#328 that handles the relative paths a bit better still. I'll update the GitHub Actions workflow to use conda-lock 2.0.0 in #14.

@weiji14
Copy link
Member

weiji14 commented Sep 26, 2023

This issue is actually referring to the lockfile on https://github.com/CryoInTheCloud/CryoCloudWebsite/tree/main/conda (where the build stuff used to happen). We've been using conda-lock>=2.0.0 for a while now on https://github.com/CryoInTheCloud/hub-image (conda-lock=2.3.0 as of #91), so I'll close down this issue. Feel free to reopen if needed.

@weiji14 weiji14 closed this as completed Sep 26, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in March 2023 Event Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
March 2023 Event
Status: ✅ Done
Milestone
No milestone
2 participants
@JessicaS11 @weiji14