Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complement com.cuperino.qprompt.appdata.xml #251

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

1Maxnet1
Copy link
Contributor

Based on what is already available in the LinuxPhoneApps listing I added some missing metainfo:

  • Adds vcs-browser url
  • Adds categories

@1Maxnet1
Copy link
Contributor Author

To me it seems that there is an issue with the CLA-Bot, which I cannot resolve from my side.

@Cuperino
Copy link
Owner

Hi @1Maxnet1,

There is an issue with the CLA-Bot, sorry about that. I need to fix that. I should have some time for that next week.

There's not much hurry because I also need to fix the AppImage builder (all the builds but the Deb package are broken actually) in order to test this with an AppImage built on the oldest supported version of Ubuntu that I can support. Older Ubuntu versions lack support for various AppData tags, which prevents them from building on those older systems. Right now our AppImages work all the way back to Ubuntu 18.04, but we've reached the threshold where we can drop support for it and go with 20.04 instead.

The CLA that you'd need to sign is this one here: https://github.com/Cuperino/Signatures/blob/main/CLA.md
Once the bot is fixed, signing will be doable from this pull request, and straight-forward. You can sign it manually but the check will still fail, because it's an authentication problem. I deleted a key I shouldn't have about a month ago, thinking it wasn't in use. Should've used a more descriptive name to avoid that!

@Cuperino Cuperino self-assigned this Apr 12, 2024
@Cuperino Cuperino added the distribution Packages, installers, and distribution methods label Apr 12, 2024
@Cuperino Cuperino added this to the 1.2 milestone Apr 12, 2024
@1Maxnet1
Copy link
Contributor Author

There is an issue with the CLA-Bot, sorry about that. I need to fix that. I should have some time for that next week.

No need to be sorry, issues can happen :) Also no hurry, take the time you need.

The CLA that you'd need to sign is this one here: https://github.com/Cuperino/Signatures/blob/main/CLA.md
Once the bot is fixed, signing will be doable from this pull request, and straight-forward. You can sign it manually but the check will still fail, because it's an authentication problem. I deleted a key I shouldn't have about a month ago, thinking it wasn't in use. Should've used a more descriptive name to avoid that!

That happens to me too sometimes ;) I'll just wait for the Bot to be working again and will then happily sign the CLA :)

Copy link

github-actions bot commented Apr 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@1Maxnet1
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@@ -27,6 +28,11 @@
<caption>Countdown on stand-by</caption>
</screenshot>
</screenshots>
<categories>
<category>Qt</category>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qt category should probably be removed since it's non-standard and QPrompt despide being made with Qt is not a Qt development tool. (I'll merge this and then remove the line. The rest is good.)

@Cuperino Cuperino merged commit 8467914 into Cuperino:main Sep 15, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
@Cuperino
Copy link
Owner

Thank you for your contribution @1Maxnet1! New release coming soon!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distribution Packages, installers, and distribution methods
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants