Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve scope of DSA vignettes #147

Open
evaenns opened this issue Jan 11, 2021 · 1 comment
Open

Resolve scope of DSA vignettes #147

evaenns opened this issue Jan 11, 2021 · 1 comment
Assignees

Comments

@evaenns
Copy link
Collaborator

evaenns commented Jan 11, 2021

I think I may have inadvertently merged the vignettes dsa_generation.Rmd and dsa_visualization.Rmd . I think dsa_visualization.Rmd could be removed and any information that I omitted on the visualization side could be added in with just a few sentences into dsa_generation.Rmd. Could you take a look @gknowlt ?

What I thought dsa_visualization.Rmd would cover is how you use dampack to visualize a DSA dataset that you have constructed yourself in some other platform (or using more sophisticated methods, including parallelization, if the model is computational burdensome). I think such instructions could wait until after submission to CRAN, but maybe we should create an issue to remind ourselves to write such instructions eventually.

@gknowlt
Copy link
Collaborator

gknowlt commented Jan 11, 2021

Yes, absolutely!

gknowlt added a commit that referenced this issue Jan 12, 2021
to be modified and added back later
#147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants