Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spool.select does not raise when a bad kwarg is entered as a coordinate #435

Open
ahmadtourei opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ahmadtourei
Copy link
Collaborator

Description

Entering an incorrect coordinate as an argument in the select function does not raise an error, but it would be better if it did.

Example

import dascore as dc

spool = dc.get_example_spool()
sub_spool = spool.select(invalid_dim=(1,11))

No error is raised.

Expected behavior

Versions

  • OS [e.g. Ubuntu 20.04]:
  • DasCore Version [e.g. 0.0.5]:
  • Python Version [e.g. 3.10]:
@ahmadtourei ahmadtourei added the bug Something isn't working label Sep 24, 2024
@ahmadtourei ahmadtourei changed the title select does not raise when a bad kwarg is entered as a coordinate Spool.select does not raise when a bad kwarg is entered as a coordinate Sep 24, 2024
@d-chambers
Copy link
Contributor

Patch also doesn't do this, an error message on both would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants