Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine registration task #81

Open
qigongFDA opened this issue Aug 27, 2018 · 7 comments
Open

refine registration task #81

qigongFDA opened this issue Aug 27, 2018 · 7 comments

Comments

@qigongFDA
Copy link
Contributor

We want to create one task for refine registration. For one slide registered in previous study, user can skip whole global registration. Before evaluate the study ROI on the slide, user should use this task to refine registration.

The ROI of this task is predefined in input file. During the task, stage should automatically move to the ROI or surrounding area. User can use any magnification for searching and moves stage to let the center of WSI is in the center of eyepiece, then uses 40x to refine registration.

@qigongFDA
Copy link
Contributor Author

User might need to use low magnification WSI to search the ROI, and high magnification WSI to do registration. We the to show both low and high magnifications ROI. There are two plans:

Plan A: Add a "switch button" in task panel. It can switch the WSI ROI between 10x and 40x.
Plan B: In eeDAP GUI, only show 40x ROI, and open imagescope with ROI annotation.

Plan B gives user more flexibility, user can choose WSI magnification based on the lens. But the WSI image has to be in the format, which can be read by imagescope.

@brandon-gallas
Copy link
Member

OK. How about this?
Once you have the task working, can we call that task from the GUI instead of including it in the input file?
I still think I like a GUI button "New Slide" or "Needs Registration" or "Register".
When you click this button, it takes you to the task you are talking about.
This task needs the location to do the registration.
We can get that knowing the slide ... We can use the location of the first registration anchor.

@brandon-gallas
Copy link
Member

I don't think we should involve imagescope.
I like plan A. I'm happy to extract registration images on the fly (not extract ahead of time).

@qigongFDA
Copy link
Contributor Author

qigongFDA commented Aug 31, 2018

refineregistration
Here is a flowchart for this feature.
RefineRegistration.pptx

@brandon-gallas
Copy link
Member

Looks good. Let me know progress.
BTW, I think this "task" can be integrated into other tasks ... as an option or always available.

@qigongFDA
Copy link
Contributor Author

Yes. The "Refine_Register" button is in "Control Panel". This feature should be available for all original tasks.

qigongFDA added a commit that referenced this issue Sep 7, 2018
1. One point high resolution global registration. More detail can be found in issue 80 #80

2. Refine global registration during study. More detail can be found in issue 81 #81
@qigongFDA
Copy link
Contributor Author

  1. New flowchart
    flowchart

  2. Variable and procedure path
    variablepath
    RefineRegistration.pptx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants