a little problem in plotConcHist, plotConcHistBoot, plotFluxHist, and plotFluxHistBoot

[rmhirsch49]

The problem is this. When the user doesn't specify an upper limit to the yaxix (concMax, or fluxMax) the code doesn't look at the genConc or genFlux values to pick up a suitable upper limit for the axis. I am sure this comes about because we didn't make a change to this when we implemented WRTDSKalman as an option. The consequence of this is that it is quite possible for these functions to generate plots that fail to show some of the higher values. I've had that happen to me. Fortunately I noticed a problem and could fix it by adding the concMax or fluxMax arguments. but we need to make it automatic.

Thanks. Bob

[ldecicco-USGS]

There is code in those functions that look to me like they incorporating both the regular and generalized values to get a max y value.

https://github.com/DOI-USGS/EGRET/blob/main/R/plotConcHist.R#L183
https://github.com/DOI-USGS/EGRET/blob/main/R/plotFluxHist.R#L183

https://github.com/DOI-USGS/EGRETci/blob/main/R/plotCIs.R#L103

Could you give me an eList where you see this happening?

[rmhirsch49]

I had a problem sending the original because the attachments are too big. This should work. I’ve just given you to files here CIAnnualResults.RData and eList.RData. If you just load those two things you should be good to go. Bob From: Hirsch, Robert M ***@***.***> Date: Monday, October 28, 2024 at 9:11 AM To: DOI-USGS/EGRET ***@***.***> Cc: DeCicco, Laura A ***@***.***> Subject: Re: [EXTERNAL] Re: [DOI-USGS/EGRET] a little problem in plotConcHist, plotConcHistBoot, plotFluxHist, and plotFluxHistBoot (Issue #383) It looks like the issue comes up with the Boot versions but not the original functions like plotConcHist(). I’ve attached a test I ran and the .RData file (that contains the CIAnnualResults as well as the eList). Note the tableResults() output. The highest GenConc annual value is 12.95. When I run plotConcHist() the resulting figure is fine, but when I run plotConcHistBoot() the resulting figure truncates at 11 mg/L Thanks Bob From: Laura DeCicco ***@***.***> Date: Friday, October 25, 2024 at 4:46 PM To: DOI-USGS/EGRET ***@***.***> Cc: Hirsch, Robert M ***@***.***>, Author ***@***.***> Subject: [EXTERNAL] Re: [DOI-USGS/EGRET] a little problem in plotConcHist, plotConcHistBoot, plotFluxHist, and plotFluxHistBoot (Issue #383) This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding. There is code in those functions that look to me like they incorporating both the regular and generalized values to get a max y value. https://github.com/DOI-USGS/EGRET/blob/main/R/plotConcHist.R#L183 https://github.com/DOI-USGS/EGRET/blob/main/R/plotFluxHist.R#L183 https://github.com/DOI-USGS/EGRETci/blob/main/R/plotCIs.R#L103 Could you give me an eList where you see this happening? — Reply to this email directly, view it on GitHub<#383 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAI53UNUIAJYDDMRR7JG3YDZ5KUZVAVCNFSM6AAAAABOFS67PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYG43DGNZYGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[rmhirsch49]

Got it! I think that's been fixed, but hasn't made it to CRAN. So if you: remotes::install_github("DOI-USGS/EGRETci") then let me know if that doesn't fix it. We'll get a new update to EGRETci up to CRAN after dealing with dataRetrieval and EGRET.

…

________________________________ From: Hirsch, Robert M ***@***.***> Sent: Monday, October 28, 2024 8:11 AM To: DOI-USGS/EGRET ***@***.***> Cc: DeCicco, Laura A ***@***.***> Subject: Re: [EXTERNAL] Re: [DOI-USGS/EGRET] a little problem in plotConcHist, plotConcHistBoot, plotFluxHist, and plotFluxHistBoot (Issue #383) It looks like the issue comes up with the Boot versions but not the original functions like plotConcHist(). I’ve attached a test I ran and the .RData file (that contains the CIAnnualResults as well as the eList). Note the tableResults() output. The highest GenConc annual value is 12.95. When I run plotConcHist() the resulting figure is fine, but when I run plotConcHistBoot() the resulting figure truncates at 11 mg/L Thanks Bob From: Laura DeCicco ***@***.***> Date: Friday, October 25, 2024 at 4:46 PM To: DOI-USGS/EGRET ***@***.***> Cc: Hirsch, Robert M ***@***.***>, Author ***@***.***> Subject: [EXTERNAL] Re: [DOI-USGS/EGRET] a little problem in plotConcHist, plotConcHistBoot, plotFluxHist, and plotFluxHistBoot (Issue #383) This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding. There is code in those functions that look to me like they incorporating both the regular and generalized values to get a max y value. https://github.com/DOI-USGS/EGRET/blob/main/R/plotConcHist.R#L183 https://github.com/DOI-USGS/EGRET/blob/main/R/plotFluxHist.R#L183 https://github.com/DOI-USGS/EGRETci/blob/main/R/plotCIs.R#L103 Could you give me an eList where you see this happening? — Reply to this email directly, view it on GitHub<#383 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAI53UNUIAJYDDMRR7JG3YDZ5KUZVAVCNFSM6AAAAABOFS67PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYG43DGNZYGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>