Issue 93 #97
Merged
Issue 93 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler via a database table.
…client API log messages.
…ive; DAO uses a Lock to avoid double-closing the connection pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change vastly simplifies the code of individual delivery services, while adding extra protection against service failure.
The
BaseWriterclass accepts messages fromlogical_timeseriesRabbitMQ exchange and writes them to a service-specific database table. A thread reads from the table and invokes the service-specificon_messagemethod to deliver the message to the destination platform.on_messagemay return ok, fail, or retry. The service-specific code is responsible to deciding how many times a message should be retried before being marked as a fail.The Ubidots client code was updated to include the broker correlation id in its log messages, and also have the 0.3s delay before calls to adding data which is probably what caused some of the error responses we're seeing.