-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to set OpenCL events #39
Comments
@DTolm, I was thinking this might be handled best by adding Along these lines, I think it would be best practice to propagate events between each kernel invocation (within a single transform) to ensure synchronization. I'm not familiar with the internals of VkFFT, but one could imagine an out-of-order queue launching a kernel too early. If this sounds appropriate to you and it would be helpful, I would be willing to work on a PR. Should be pretty simple. |
@zachjweiner |
Taking a closer look, I see now that
(and as usual ensure these are zero unless the user sets them).
and, on the last,
Since Separately, it would be good to have an internal |
In the recent OpenCL backend, the kernel is enqueued with:
i.e. the last three arguments are set to 0. It would be nice to set/have access to these event arguments, which are helpful for synchronization and profiling.
The text was updated successfully, but these errors were encountered: