comp/trace/config: use dedicated testing.T in subtests

[ajgajg1134]

What does this PR do?

Fix a minor bug where if the makeProgram function failed it would improperly use the testing.T of the parent test, this causes an invalid test error and makes debugging the real failure much harder.

Motivation

Describe how to test/QA your changes

n/a

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48001433 --os-family=ubuntu

Note: This applies to commit ab5558d

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Run ID: bf66f407-a60b-4b89-a7ff-49a3efea0e10 Metrics dashboard Target profiles

Baseline: f310525
Comparison: ab5558d

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.78	[+0.05, +1.52]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.66	[+0.56, +0.75]	1	Logs bounds checks dashboard
➖	otel_to_otel_logs	ingress throughput	+0.53	[-0.27, +1.34]	1	Logs
➖	idle_all_features	memory utilization	+0.48	[+0.38, +0.59]	1	Logs bounds checks dashboard
➖	pycheck_lots_of_tags	% cpu utilization	+0.20	[-2.28, +2.67]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.19	[-0.30, +0.68]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.16	[+0.10, +0.21]	1	Logs
➖	idle	memory utilization	+0.09	[+0.04, +0.13]	1	Logs bounds checks dashboard
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.00	[-0.34, +0.33]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.24, +0.22]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.11, +0.08]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.27, +0.22]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.06	[-0.24, +0.12]	1	Logs
➖	basic_py_check	% cpu utilization	-0.08	[-2.77, +2.61]	1	Logs
➖	quality_gate_idle	memory utilization	-0.14	[-0.19, -0.09]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.14	[-0.27, -0.02]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	idle	memory_usage	10/10
✅	idle_all_features	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10
✅	quality_gate_idle_all_features	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[ajgajg1134]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!