fix(coverage): Prevent hard failure in case of empty file #30707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
added
changelog/no-changelog
qa/no-code-change
github-actions
bot
added
the
short review
CelianR
approved these changes
Nov 4, 2024
|
[Fast Unit Tests Report] On pipeline 48149673 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
amenasria
approved these changes
Nov 4, 2024
Regression Detector |
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adapt the
merge_dev_in_mainmethod to prevent hard failure when the main file is emptyMotivation
We sometimes faces failures in coverage uploadm, because some files stored in the cache are empty (in my case it was
pkg/trace/stats/oteltest/coverage.out.If such case can happen we might want to prevent such failure to occur
Describe how to test/QA your changes
No QA but we can monitor we don't have no more occurrence of some logs here
Possible Drawbacks / Trade-offs
Additional Notes