Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update processes team name to container-intake #31442

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

robertjli
Copy link
Member

@robertjli robertjli commented Nov 25, 2024

What does this PR do?

  • Update @DataDog/processes to @DataDog/container-intake in CODEOWNERS file.
  • Update ddqa config with Container Intake team
  • Update Github to Jira/Slack maps with Container Intake team

Motivation

Team is being renamed.

Describe how to test/QA your changes

N/A

Possible Drawbacks / Trade-offs

Additional Notes

@robertjli robertjli added team/processes qa/no-code-change No code change in Agent code requiring validation labels Nov 25, 2024
@robertjli robertjli added this to the 7.61.0 milestone Nov 25, 2024
@robertjli robertjli changed the title [CODEOWNERS] Update processes to container-intake Update processes team name to container-intake Nov 25, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 25, 2024
@robertjli robertjli requested review from a team as code owners November 25, 2024 20:24
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 25, 2024
@robertjli robertjli marked this pull request as draft November 25, 2024 20:34
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Nov 25, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 25, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50873354 --os-family=ubuntu

Note: This applies to commit 3f4f026

Copy link

cit-pr-commenter bot commented Nov 25, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8a6d5917-74a1-47de-b750-6ad14f4071a1

Baseline: 3c882e7
Comparison: 3f4f026
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +1.16 [+1.04, +1.28] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.35, +0.48] 1 Logs
quality_gate_idle memory utilization +0.25 [+0.21, +0.30] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.69, +0.83] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.08, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.62] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.89, +0.84] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.80, +0.71] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.92, +0.79] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.07 [-0.53, +0.40] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.10 [-0.93, +0.73] 1 Logs
otel_to_otel_logs ingress throughput -0.23 [-0.95, +0.49] 1 Logs
quality_gate_logs % cpu utilization -0.24 [-3.17, +2.68] 1 Logs
file_tree memory utilization -0.33 [-0.45, -0.21] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.52 [-1.30, +0.27] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -3.56 [-4.28, -2.84] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@robertjli
Copy link
Member Author

Re: failing job dd-gitlab/tests_windows-x64, Agent DevX is bumping the memory limits for the Windows test runner in #31489

@robertjli robertjli marked this pull request as ready for review November 26, 2024 17:08
@robertjli robertjli requested review from a team as code owners November 26, 2024 17:08
@robertjli robertjli requested a review from hush-hush November 26, 2024 17:08
@robertjli robertjli modified the milestones: 7.61.0, 7.62.0 Nov 26, 2024
@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 3c882e71c8b1830d40be8d4cfae580e40414d207

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.01MB ⚠️ 1265.87MB 1265.86MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.28MB 113.28MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.41MB 78.41MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 526.65MB 526.65MB 70.00MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 1275.11MB 1275.10MB 140.00MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 1275.11MB 1275.10MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.35MB 113.35MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.49MB 78.49MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.49MB 78.49MB 10.00MB
datadog-agent-arm64-deb 0.00MB 1000.87MB 1000.87MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.77MB 108.77MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.64MB 55.64MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB 1010.08MB 1010.08MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.84MB 108.84MB 10.00MB

Decision

⚠️ Warning

@robertjli
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 12, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-12 16:33:27 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2024-12-12 17:15:05 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8a55e93 into main Dec 12, 2024
224 checks passed
@dd-mergequeue dd-mergequeue bot deleted the robertjli/PROCS-4380-cint-codeowner branch December 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/container-intake team/processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants