Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ddflare ocb integration test #31665

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jackgopack4
Copy link
Contributor

What does this PR do?

disables DDFlare OCB test until go.work is implemented

Motivation

#31595 failed due to modules not being published yet

Describe how you validated your changes

disabled test, none needed

Possible Drawbacks / Trade-offs

need to re-enable test once go.work is enabled to see if it works
https://datadoghq.atlassian.net/browse/OTEL-2287

Additional Notes

@jackgopack4 jackgopack4 requested review from a team as code owners December 2, 2024 16:38
@github-actions github-actions bot added team/agent-devx-infra short review PR is simple enough to be reviewed quickly team/opentelemetry OpenTelemetry team labels Dec 2, 2024
@agent-platform-auto-pr
Copy link
Contributor

Gitlab CI Configuration Changes

Modified Jobs

ddflare_extension_ocb_build
  ddflare_extension_ocb_build:
    before_script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache.tar.xz
    - mkdir -p /tmp/otel-ci
    - cp test/otel/testdata/* /tmp/otel-ci/
    - wget -O /tmp/otel-ci/ocb https://github.com/open-telemetry/opentelemetry-collector-releases/releases/download/cmd%2Fbuilder%2Fv0.114.0/ocb_0.114.0_linux_amd64
    - chmod +x /tmp/otel-ci/ocb
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - go_deps
    rules:
-   - if: $CI_PIPELINE_SOURCE =~ /^schedule.*$/
-     when: never
?   ^
+   - when: never
?   ^
-   - if: $CI_COMMIT_TAG
-     when: never
-   - if: $CI_COMMIT_MESSAGE =~ /.*\[skip cancel\].*/
-     when: never
-   - if: $CI_COMMIT_REF_NAME =~ /.*-skip-cancel$/
-     when: never
-   - when: always
    script:
    - echo 'Building collector with OCB and test ddflare extension'
    - /tmp/otel-ci/ocb --config=/tmp/otel-ci/builder-config.yaml > ocb-output.log 2>&1
    - grep -q 'Compiled' ocb-output.log || (echo "OCB failed to compile" && exit 1)
    - 'grep -q ''{"binary": "/tmp/otel-ci/otelcol-custom/otelcol-custom"}'' ocb-output.log
      || (echo "OCB failed to compile" && exit 1)'
    - /tmp/otel-ci/otelcol-custom/otelcol-custom --config /tmp/otel-ci/collector-config.yaml
      > otelcol-custom.log 2>&1 &
    - OTELCOL_PID=$!
    - sleep 10
    - grep -q 'Everything is ready. Begin running and processing data.' otelcol-custom.log
      || (echo "custom collector failed to start" && kill $OTELCOL_PID && exit 1)
    - curl -k https://localhost:7777 > flare-info.log 2>&1
    - 'grep -q ''"provided_configuration": ""'' flare-info.log || (echo "provided config
      should not be supported with ocb" && kill $OTELCOL_PID && exit 1)'
    - grep -q 'extensions:\\n  - ddflare\\n' flare-info.log || (echo "ddflare extension
      should be enabled" && kill $OTELCOL_PID && exit 1)
    - kill $OTELCOL_PID
    stage: integration_test
    tags:
    - arch:amd64

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

Copy link
Member

@mackjmr mackjmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you add a comment explaining why were disabling it and that we will re-enable in future

@mackjmr mackjmr removed the request for review from ankitpatel96 December 2, 2024 16:49
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50219084 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@jackgopack4 jackgopack4 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 2, 2024
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 48fd27d3-33e2-42c8-b9cc-883b9eaee6e0

Baseline: 0200b9d
Comparison: 745078b
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization -5.60 [-9.38, -1.83] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +2.72 [-0.78, +6.22] 1 Logs
file_tree memory utilization +0.57 [+0.42, +0.71] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.25 [+0.18, +0.32] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.06 [-0.57, +0.69] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.72, +0.83] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.71, +0.75] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.83, +0.88] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.86, +0.71] 1 Logs
quality_gate_idle memory utilization -0.27 [-0.31, -0.22] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.57 [-1.03, -0.12] 1 Logs
quality_gate_idle_all_features memory utilization -0.66 [-0.78, -0.54] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.72 [-1.41, -0.03] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.83 [-1.56, -0.09] 1 Logs
quality_gate_logs % cpu utilization -1.50 [-4.48, +1.48] 1 Logs
basic_py_check % cpu utilization -5.60 [-9.38, -1.83] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@jackgopack4 jackgopack4 marked this pull request as draft December 3, 2024 21:24
@jackgopack4
Copy link
Contributor Author

converted to draft since go.work is now committed

@jackgopack4
Copy link
Contributor Author

once #31941 is merged I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx-infra team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants