Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM] Add cilium lb conntracker #31842

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

hmahmood
Copy link
Contributor

@hmahmood hmahmood commented Dec 6, 2024

What does this PR do?

Adds a new flavor of conntracker that tracks address translations done by Cilium. This uses the cilium eBPF maps to lookup up address translations. Note that access to cilium's maps requires mounting /sys/fs/bpf, something that is not done by the public helm chart currently by default if system-probe is enabled.

Motivation

Customer reports of cluster IPs not getting translated by NPM and thus not showing any tags in the UI.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@hmahmood hmahmood added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 6, 2024
@hmahmood hmahmood added this to the 7.62.0 milestone Dec 6, 2024
@hmahmood hmahmood requested review from a team as code owners December 6, 2024 17:16
@hmahmood hmahmood requested a review from akarpz December 6, 2024 17:16
@github-actions github-actions bot added component/system-probe medium review PR review might take time long review PR is complex, plan time to review it and removed medium review PR review might take time labels Dec 6, 2024
Copy link

cit-pr-commenter bot commented Dec 6, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3328870e-a699-4ef5-8781-1b6d13fc00fd

Baseline: 12815d6
Comparison: a78d08a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.33 [+1.27, +1.40] 1 Logs
otel_to_otel_logs ingress throughput +0.46 [-0.21, +1.13] 1 Logs
quality_gate_idle_all_features memory utilization +0.32 [+0.22, +0.43] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.25 [+0.20, +0.29] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.10 [-0.76, +0.96] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.08 [-0.64, +0.80] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [-0.69, +0.80] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.73, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.60, +0.69] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.00 [-0.47, +0.47] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.14 [-0.91, +0.64] 1 Logs
file_tree memory utilization -0.35 [-0.49, -0.22] 1 Logs
quality_gate_logs % cpu utilization -2.12 [-5.05, +0.80] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 7/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@hmahmood hmahmood force-pushed the hasan.mahmood/cilium-lb branch from 33b7dbf to d78b9d4 Compare December 6, 2024 21:38
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 6, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50624779 --os-family=ubuntu

Note: This applies to commit a78d08a

@hmahmood hmahmood force-pushed the hasan.mahmood/cilium-lb branch from 19d783e to 1803a5c Compare December 9, 2024 18:24
@hmahmood hmahmood force-pushed the hasan.mahmood/cilium-lb branch from 1803a5c to a78d08a Compare December 9, 2024 19:27
return netlink.NewNoOpConntracker(), nil
}

ctTCP, err := ebpf.LoadPinnedMap("/sys/fs/bpf/tc/globals/cilium_ct4_global", &ebpf.LoadPinOptions{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just want to make sure we already had permissions to access this, and if not do we have to make changes in the chart etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently not in the chart; we will have to add it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I just saw this in the description, is there a ticket for this

}

func (clb *ciliumLoadBalancerConntracker) GetTranslationForConn(c *network.ConnectionTuple) *network.IPTranslation {
// TODO: add ipv6 support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a ticket for this? I'm worried it will get lost

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks

func (clb *ciliumLoadBalancerConntracker) Close() {
clb.stop <- struct{}{}
<-clb.stop
clb.ctTCP.Map().Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in other places in the code we wrap certain cleanup in a sync.Once so that in case close is called multiple times, we can avoid panics. Would it be useful to do that here?

log.Warnf("could not initialize conntrack, tracer will continue without NAT tracking: %s", err)
return netlink.NewNoOpConntracker(), nil
c = chainConntrackers(c, clb)
if c.GetType() == "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to read the impl type directly here?

return "chain"
}

func (ct *chainConntracker) DeleteTranslation(c *network.ConnectionTuple) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: exported methods should be have comments (why doesn't the linter care?)

@akarpz
Copy link
Contributor

akarpz commented Dec 12, 2024

I don't foresee this having a huge perf impact, but was it tested anywhere?

var err error
if err = queryMap.Lookup(&t, &ctEntry); err != nil {
if !errors.Is(err, ebpf.ErrKeyNotExist) {
log.Warnf("error looking up %+v in ct map: %s", t, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add any prometheus telemetry around these errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants