Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2586] Migrating SecurityAgent to use IPC cert #31845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

misteriaud
Copy link
Contributor

@misteriaud misteriaud commented Dec 6, 2024

What does this PR do?

This PR replaces the self-signed certificate used in the Security Agent with the new Agent-wide IPC certificate. This change will allow Agents to identify this API as legitimate when they act as a client.

The certificate generation/retrieval implementation have been made in the following PR:

Motivation

This PR takes place in a plan of Agent security IPC improvement.

Describe how you validated your changes

We might need to implement some e2e test to cover this change.

Additional Notes

@misteriaud misteriaud force-pushed the misteriaud/ASCII-2586-migrating-security-agent-to-use-IPC-cert branch from cf77b11 to 4fdafc8 Compare December 6, 2024 17:43
@misteriaud misteriaud changed the title Add /pkg/api/security/cert package to handle IPC certificate and key … [ASCII-2586] Migrating SecurityAgent to use IPC cert Dec 6, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 6, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50932720 --os-family=ubuntu

Note: This applies to commit 0fa6bd9

@misteriaud misteriaud force-pushed the misteriaud/ASCII-2586-migrating-security-agent-to-use-IPC-cert branch from 4fdafc8 to 8a88dd2 Compare December 6, 2024 19:47
@misteriaud misteriaud force-pushed the misteriaud/ASCII-2582-implement-IPC-cert/key-creation branch 2 times, most recently from d1bd1c3 to 853a60e Compare December 9, 2024 13:51
@misteriaud misteriaud force-pushed the misteriaud/ASCII-2586-migrating-security-agent-to-use-IPC-cert branch 4 times, most recently from cc00153 to 59914e6 Compare December 11, 2024 12:21
@misteriaud misteriaud marked this pull request as ready for review December 11, 2024 12:52
@misteriaud misteriaud requested a review from a team as a code owner December 11, 2024 12:52
Copy link

cit-pr-commenter bot commented Dec 11, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5ff9861f-c9c0-4068-b62c-aa016bf3b355

Baseline: c96e647
Comparison: 0fa6bd9
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.71 [-0.02, +1.44] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.38 [+0.32, +0.45] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.33 [-0.14, +0.79] 1 Logs
quality_gate_logs % cpu utilization +0.23 [-2.72, +3.18] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.07 [-0.79, +0.93] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.73, +0.82] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.59, +0.67] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.69, +0.71] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.86, +0.87] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.10, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.81, +0.73] 1 Logs
quality_gate_idle memory utilization -0.39 [-0.43, -0.35] 1 Logs bounds checks dashboard
file_tree memory utilization -0.42 [-0.54, -0.31] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.66 [-1.45, +0.12] 1 Logs
otel_to_otel_logs ingress throughput -1.04 [-1.70, -0.37] 1 Logs
quality_gate_idle_all_features memory utilization -2.78 [-2.90, -2.66] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_300ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@misteriaud misteriaud force-pushed the misteriaud/ASCII-2586-migrating-security-agent-to-use-IPC-cert branch from 59914e6 to bed2ae8 Compare December 11, 2024 14:43
@misteriaud misteriaud force-pushed the misteriaud/ASCII-2586-migrating-security-agent-to-use-IPC-cert branch from bed2ae8 to e835645 Compare December 11, 2024 16:51
Base automatically changed from misteriaud/ASCII-2582-implement-IPC-cert/key-creation to main December 12, 2024 08:19
@dd-mergequeue dd-mergequeue bot requested a review from a team as a code owner December 12, 2024 08:19
@dd-mergequeue dd-mergequeue bot requested a review from jeremy-hanna December 12, 2024 08:19
@misteriaud misteriaud force-pushed the misteriaud/ASCII-2586-migrating-security-agent-to-use-IPC-cert branch from e835645 to 0fa6bd9 Compare December 12, 2024 10:16
@misteriaud misteriaud removed request for a team and jeremy-hanna December 12, 2024 10:16
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 12, 2024
@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor c96e64710cdd2f6683e54fe07067b4273291eb98

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -0.02MB 1265.97MB 1265.99MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.27MB 113.27MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.50MB 78.50MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 526.73MB 526.73MB 70.00MB
datadog-agent-x86_64-rpm -0.02MB 1275.21MB 1275.22MB 140.00MB
datadog-agent-x86_64-suse -0.02MB 1275.21MB 1275.22MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.33MB 113.33MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.58MB 78.58MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.58MB 78.58MB 10.00MB
datadog-agent-arm64-deb -0.01MB 1000.97MB 1000.98MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.75MB 108.75MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.73MB 55.73MB 10.00MB
datadog-agent-aarch64-rpm -0.01MB 1010.19MB 1010.20MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.82MB 108.82MB 10.00MB

Decision

✅ Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants