Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASCII-2461] Fix flaky TestRunProviders #31879

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[ASCII-2461] Fix flaky TestRunProviders #31879

merged 3 commits into from
Dec 11, 2024

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Dec 9, 2024

What does this PR do?

Update TestRunProviders to fix a race condition.
Still check that providers are started, and that we don't wait for them forever.

Motivation

Not have a race.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac added changelog/no-changelog team/agent-shared-components qa/no-code-change No code change in Agent code requiring validation labels Dec 9, 2024
@pgimalac pgimalac requested a review from a team as a code owner December 9, 2024 12:45
@pgimalac pgimalac requested a review from dustmop December 9, 2024 12:45
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 9, 2024
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 9, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 9, 2024 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50745604 --os-family=ubuntu

Note: This applies to commit 2dad873

@pgimalac
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-11 12:39:17 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-11 13:02:40 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 24m.

2024-12-11 13:31:01 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 6d7ae5b into main Dec 11, 2024
219 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/test-run-providers-flaky-timeout branch December 11, 2024 13:31
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustmop dustmop dustmop approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-shared-components
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pgimalac @dustmop