Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix CODEOWNERS due to team split #31896

Merged
merged 1 commit into from
Dec 10, 2024
Merged

ci: Fix CODEOWNERS due to team split #31896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
/.gitlab/binary_build/system_probe.yml @DataDog/ebpf-platform @DataDog/agent-delivery
/.gitlab/binary_build/windows.yml @DataDog/agent-delivery @DataDog/windows-agent

/.gitlab/benchmarks/ @DataDog/agent-devx-infra @DataDog/apm-reliability-and-performance @DataDog/agent-apm
/.gitlab/benchmarks/ @DataDog/agent-devx-infra @DataDog/apm-ecosystems-performance @DataDog/agent-apm

/.gitlab/deploy_containers/ @DataDog/container-integrations @DataDog/agent-delivery
/.gitlab/deploy_dca/ @DataDog/container-integrations @DataDog/agent-delivery
Expand Down
2 changes: 1 addition & 1 deletion tasks/libs/pipeline/github_slack_map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@
'@datadog/agent-devx-infra': '#agent-devx-ops'
'@datadog/agent-devx-loops': '#agent-devx-ops'
'@datadog/apm-onboarding': '#apm-onboarding'
'@datadog/apm-reliability-and-performance': '#apm-ecosystems-reliability'
'@datadog/apm-ecosystems-performance': '#apm-benchmarking-platform'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a split, shouldn't this be two lines containing two teams?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for question Celian!
No, the change is correct. After split, only my team owns CI code of benchmarking CI job for trace-agent.
#apm-ecosystems-reliability (the other team) doesn't own anything in datadog-agent repo as of now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't merge the changes though (see "Merging is blocked" in Github). @CelianR could you please click merge button? 🙏 🙇

'@DataDog/container-ecosystems': '#container-ecosystems-ops'
Loading