Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usm] system-probe, http statskeeper, add pool of ddsketch objects #31901

Closed

Conversation

yuri-lipnesh
Copy link
Contributor

@yuri-lipnesh yuri-lipnesh commented Dec 9, 2024

What does this PR do?

Adds pool of DDSketch objects to StatKeeper struct.

Motivation

This is part of an effort to improve USM performance and reliability.
Profiling shows frequently allocated objects of 'DDSketch', using pool of these objects should decrease memory utilization.

Benchmarking on local VM shows shows allocation decrease 3.7 times:

pkg: github.com/DataDog/datadog-agent/pkg/network/protocols/http
BenchmarkHTTPStatkeeperWithPool-4   	     100	  10853091 ns/op	   86515 B/op	     651 allocs/op
BenchmarkHTTPStatkeeperNoPool-4     	     100	  11162432 ns/op	  338688 B/op	    2414 allocs/op

Describe how you validated your changes

Covered by unit tests.

Possible Drawbacks / Trade-offs

Additional Notes

@yuri-lipnesh yuri-lipnesh added changelog/no-changelog component/system-probe team/usm The USM team qa/done QA done before merge and regressions are covered by tests labels Dec 9, 2024
@github-actions github-actions bot added the medium review PR review might take time label Dec 9, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50624672 --os-family=ubuntu

Note: This applies to commit d6b8218

@yuri-lipnesh yuri-lipnesh deleted the yuri.lipnesh/USMON-1324_http_ddsketch_benchmark branch December 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant