Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsConfigured to the config interface #31974

Open
wants to merge 1 commit into
base: maxime/bump-viper
Choose a base branch
from

Conversation

hush-hush
Copy link
Member

What does this PR do?

Exposing new method IsConfigured for the configuration and deprecating IsSet.

Describe how you validated your changes

Unit test where added for the method and it not used anywhere yet.

@hush-hush hush-hush requested a review from a team as a code owner December 10, 2024 15:33
@hush-hush hush-hush requested a review from dustmop December 10, 2024 15:33
@hush-hush hush-hush added changelog/no-changelog team/agent-shared-components qa/done QA done before merge and regressions are covered by tests labels Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

Package size comparison

Comparison with ancestor 6b70b84aebd4b35f9661d0fb3fe97dbe6f90dddf

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.05MB ⚠️ 1271.67MB 1271.61MB 140.00MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 113.30MB 113.29MB 10.00MB
datadog-dogstatsd-amd64-deb 0.02MB ⚠️ 78.43MB 78.41MB 10.00MB
datadog-heroku-agent-amd64-deb 0.04MB ⚠️ 526.69MB 526.65MB 70.00MB
datadog-agent-x86_64-rpm 0.05MB ⚠️ 1280.90MB 1280.85MB 140.00MB
datadog-agent-x86_64-suse 0.05MB ⚠️ 1280.90MB 1280.85MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 113.37MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 113.37MB 113.35MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.02MB ⚠️ 78.51MB 78.49MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.02MB ⚠️ 78.51MB 78.49MB 10.00MB
datadog-agent-arm64-deb 0.05MB ⚠️ 1005.73MB 1005.67MB 140.00MB
datadog-iot-agent-arm64-deb 0.02MB ⚠️ 108.78MB 108.76MB 10.00MB
datadog-dogstatsd-arm64-deb 0.02MB ⚠️ 55.66MB 55.64MB 10.00MB
datadog-agent-aarch64-rpm 0.05MB ⚠️ 1014.94MB 1014.89MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.02MB ⚠️ 108.85MB 108.83MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50854893 --os-family=ubuntu

Note: This applies to commit a9ba1a3

Copy link

cit-pr-commenter bot commented Dec 10, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3fc00e26-95fd-4e52-8908-a428a700f628

Baseline: 6b70b84
Comparison: a9ba1a3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.77 [+0.04, +1.50] 1 Logs
otel_to_otel_logs ingress throughput +0.44 [-0.23, +1.11] 1 Logs
quality_gate_idle memory utilization +0.42 [+0.38, +0.46] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.30 [-2.63, +3.23] 1 Logs
file_tree memory utilization +0.23 [+0.11, +0.35] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.12 [-0.66, +0.90] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.82, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.84, +0.85] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.77, +0.75] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.64, +0.61] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.80, +0.75] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.06 [-0.18, +0.06] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.85, +0.67] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.12 [-0.58, +0.34] 1 Logs
quality_gate_idle_all_features memory utilization -0.79 [-0.90, -0.68] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@hush-hush hush-hush requested review from a team as code owners December 11, 2024 15:40
@hush-hush hush-hush requested review from dineshg13 and removed request for a team December 11, 2024 15:40
@hush-hush hush-hush force-pushed the maxime/expose-isconfigured-method branch from f1ea74a to b7d3ea7 Compare December 11, 2024 15:41
@vickenty vickenty removed the request for review from a team December 11, 2024 15:59
@hush-hush hush-hush force-pushed the maxime/expose-isconfigured-method branch from b7d3ea7 to a9ba1a3 Compare December 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant