Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fleet] First working set of databricks script e2e #31984

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

raphaelgavache
Copy link
Member

What does this PR do?

Enforce that we don't break the install script for amd/arm and that databricks script install the proper packages!
I didn't cleanly setup the installer yet, just executing its setup on the script start as a temporary hack to make the e2e work

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@raphaelgavache raphaelgavache requested review from a team as code owners December 10, 2024 20:13
@github-actions github-actions bot added team/windows-agent medium review PR review might take time labels Dec 10, 2024
@raphaelgavache raphaelgavache added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 90e7b919ad017c84f751b2dbb8ea1d2b5e4ebe0b

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -1.40MB 1271.29MB 1272.69MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ⚠️ 526.45MB 526.45MB 70.00MB
datadog-agent-x86_64-rpm -1.40MB 1280.52MB 1281.92MB 140.00MB
datadog-agent-x86_64-suse -1.40MB 1280.52MB 1281.92MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.26MB 113.26MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.26MB 113.26MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.01MB ⚠️ 1005.44MB 1005.44MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.67MB 108.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 1014.66MB 1014.65MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.74MB 108.74MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50761479 --os-family=ubuntu

Note: This applies to commit 02cbdc0

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 054412f7-1770-4550-a880-5da7e7d1c68c

Baseline: 90e7b91
Comparison: 02cbdc0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.17 [-0.78, +5.11] 1 Logs
otel_to_otel_logs ingress throughput +0.50 [-0.16, +1.17] 1 Logs
quality_gate_idle_all_features memory utilization +0.25 [+0.15, +0.36] 1 Logs bounds checks dashboard
file_tree memory utilization +0.18 [+0.05, +0.31] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.59, +0.67] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.79, +0.85] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.74, +0.80] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.07, +0.10] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.87, +0.91] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.77, +0.80] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.91, +0.80] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.11 [-0.21, -0.01] 1 Logs
quality_gate_idle memory utilization -0.31 [-0.36, -0.27] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.35 [-1.08, +0.37] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.48 [-1.26, +0.30] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.69 [-1.15, -0.22] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http2 lost_bytes 9/10
file_to_blackhole_300ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@raphaelgavache
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-11 08:47:33 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 496b97f into main Dec 11, 2024
259 of 261 checks passed
@dd-mergequeue dd-mergequeue bot deleted the raphael/databricks_fixes branch December 11, 2024 09:11
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/windows-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants