[EBPF] Ignore unchanged programs when calculating complexity changes #32015
Conversation
gjulianm
added
changelog/no-changelog
qa/no-code-change
github-actions
bot
added
the
short review
tasks/ebpf.py
Outdated
| @@ -724,6 +724,7 @@ def _try_delete_github_comment(msg: str): | |||
|
|
|||
| current_branch_artifacts_path = Path(current_branch_artifacts_path) | |||
| complexity_files = list(current_branch_artifacts_path.glob("verifier-complexity-*.tar.gz")) | |||
| print(complexity_files) | |||
There was a problem hiding this comment.
Woops, forgotten debug print 😅
github-actions
bot
added
medium review
|
[Fast Unit Tests Report] On pipeline 50832870 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c239913 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.88 | [+0.82, +0.94] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.44 | [-0.29, +1.17] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.33 | [+0.29, +0.38] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.77, +0.78] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.01 | [-0.80, +0.79] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.13, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.90, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.03 | [-0.85, +0.78] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.76, +0.65] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.06 | [-0.17, +0.06] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.16 | [-0.79, +0.47] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.22 | [-3.14, +2.69] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.38 | [-0.50, -0.26] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.43 | [-0.89, +0.04] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.56 | [-1.35, +0.22] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -1.00 | [-1.72, -0.28] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
Devflow running:
|
dd-mergequeue
bot
deleted the
guillermo.julian/fix-ebpf-complexity-improvements
branch
What does this PR do?
This PR fixes the
ebpf.generate-complexity-summary-for-prtask, which reports that the "highest complexity change" is 0 when complexity is reduced in some programs and others are unchanged. Now only programs that have complexity changes are taken into account for that summary, which is more in-line with how the task ignores unchanged object files, for example.Motivation
See #31947 (comment) for an example of a PR with an erroneous comment.
Describe how you validated your changes
Tested locally.
Possible Drawbacks / Trade-offs
Additional Notes