Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wmeta: Add GPU entity #32019

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Dec 11, 2024

What does this PR do?

This PR adds definitions of GPU devices to workloadmeta. This data will be filled by the GPU monitoring module and used by the tagger in other PRs.

Motivation

Share the GPU devices detected to allow further integration with other parts of the agent.

Describe how you validated your changes

Added unit tests for the functional parts of the code.

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm self-assigned this Dec 11, 2024
@github-actions github-actions bot added medium review PR review might take time team/container-platform The Container Platform Team labels Dec 11, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50854783 --os-family=ubuntu

Note: This applies to commit 3511c39

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 11, 2024

Package size comparison

Comparison with ancestor c23991318bdae9f2137171b7d8d44e7753d2e346

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.03MB ⚠️ 1271.37MB 1271.34MB 140.00MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 113.23MB 113.22MB 10.00MB
datadog-dogstatsd-amd64-deb 0.01MB ⚠️ 78.34MB 78.33MB 10.00MB
datadog-heroku-agent-amd64-deb 0.01MB ⚠️ 526.50MB 526.49MB 70.00MB
datadog-agent-x86_64-rpm 0.03MB ⚠️ 1280.60MB 1280.57MB 140.00MB
datadog-agent-x86_64-suse 0.03MB ⚠️ 1280.60MB 1280.57MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 113.30MB 113.29MB 10.00MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 113.30MB 113.29MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.01MB ⚠️ 78.42MB 78.41MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.01MB ⚠️ 78.42MB 78.41MB 10.00MB
datadog-agent-arm64-deb 0.03MB ⚠️ 1005.50MB 1005.48MB 140.00MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 108.72MB 108.71MB 10.00MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 55.60MB 55.60MB 10.00MB
datadog-agent-aarch64-rpm 0.03MB ⚠️ 1014.72MB 1014.69MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 108.79MB 108.78MB 10.00MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Dec 11, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8345da01-330c-4754-ab14-258b0cdc5ab4

Baseline: c239913
Comparison: 3511c39
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +0.98 [+0.27, +1.68] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.36 [-0.43, +1.15] 1 Logs
quality_gate_idle memory utilization +0.35 [+0.30, +0.39] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.25 [-0.21, +0.71] 1 Logs
file_tree memory utilization +0.23 [+0.11, +0.35] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.09 [-0.54, +0.72] 1 Logs
quality_gate_idle_all_features memory utilization +0.06 [-0.07, +0.20] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.79, +0.82] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.85, +0.88] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.85, +0.83] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.15, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.78, +0.72] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.81, +0.74] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.56 [-1.29, +0.16] 1 Logs
quality_gate_logs % cpu utilization -0.62 [-3.54, +2.29] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.96 [-2.02, -1.90] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@gjulianm gjulianm added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 11, 2024
@gjulianm gjulianm force-pushed the guillermo.julian/gpu-workloadmeta branch from 36b9fa0 to 6f0a929 Compare December 11, 2024 15:01
@gjulianm gjulianm force-pushed the guillermo.julian/gpu-workloadmeta branch from 6f0a929 to 3511c39 Compare December 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant