usm: kafka: Check packet size before load #32028
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitkyrka
added
changelog/no-changelog
team/usm
github-actions
bot
added
component/system-probe
short review
guyarb
approved these changes
Dec 11, 2024
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check the packet size before load to avoid helper errors reported by telemetry.
Motivation
Noticed while making code changes to add kprobe support
Describe how you validated your changes
Code is covered by automated tests.
I ran it on one host in a staging cluster and there the errors from the
datadog.system_probe.ebpf.helpers.errors{helper:bpf_skb_load_bytes,probe_name:socket_kafka_filter}metric went to zero:Possible Drawbacks / Trade-offs
Additional Notes