feat(installer): Publish install scripts on installtesting.datad0g.com on success on main #32084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitlab CI Configuration ChangesAdded Jobs.if_not_main_branch.if_not_main_branch:
if: $CI_COMMIT_BRANCH != "main".only_main.only_main:
- if: $CI_COMMIT_BRANCH != "main"
when: neverqa_installer_script_mainqa_installer_script_main:
before_script:
- ls $OMNIBUS_PACKAGE_DIR
image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- new-e2e-installer-script
- installer-install-scripts
rules:
- if: $CI_COMMIT_BRANCH != "main"
when: never
- if: $RUN_E2E_TESTS == "off"
when: never
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- if: $RUN_E2E_TESTS == "on"
when: on_success
- if: $CI_COMMIT_BRANCH == "main"
when: on_success
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
when: on_success
- if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
when: on_success
- changes:
compare_to: main
paths:
- .gitlab/e2e/e2e.yml
- test/new-e2e/pkg/**/*
- test/new-e2e/go.mod
- flakes.yaml
- changes:
compare_to: main
paths:
- .gitlab/**/*
- omnibus/config/**/*
- pkg/fleet/**/*
- cmd/installer/**/*
- test/new-e2e/tests/installer/**/*
- tasks/installer.py
when: on_success
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- allow_failure: true
when: manual
script:
- $S3_CP_CMD --recursive --exclude "*" --include "install-*.sh" "$OMNIBUS_PACKAGE_DIR"
"s3://${INSTALLER_TESTING_S3_BUCKET}/scripts/"
stage: e2e_install_packages
tags:
- arch:amd64Changes Summary
ℹ️ Diff available in the job log. |
github-actions
bot
added
short review
BaptisteFoy
force-pushed
the
baptiste.foy/FA/promote-scripts-on-main
branch
from
96c18fc to
9cb6c7f
Compare
BaptisteFoy
added
changelog/no-changelog
qa/no-code-change
BaptisteFoy
force-pushed
the
baptiste.foy/FA/promote-scripts-on-main
branch
2 times, most recently
from
7633667 to
37da25b
Compare
|
[Fast Unit Tests Report] On pipeline 50942588 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
BaptisteFoy
force-pushed
the
baptiste.foy/FA/promote-scripts-on-main
branch
from
37da25b to
dfbafbf
Compare
github-actions
bot
added
medium review
BaptisteFoy
force-pushed
the
baptiste.foy/FA/promote-scripts-on-main
branch
from
dfbafbf to
0a0407c
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c96e647 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_idle_all_features | memory utilization | +2.11 | [+1.98, +2.23] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.44 | [-0.28, +1.16] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.42 | [-0.04, +0.88] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.35 | [+0.31, +0.39] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.27 | [-0.54, +1.07] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.21 | [+0.10, +0.33] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.10 | [-0.70, +0.91] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.04 | [-0.60, +0.68] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.87, +0.94] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.77, +0.79] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.02] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.11, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.71, +0.69] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.04 | [-0.92, +0.83] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.59 | [-1.27, +0.08] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.80 | [-0.86, -0.74] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.95 | [-3.88, +1.98] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 7/10 | |
| ❌ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 8/10 | |
| ❌ | file_to_blackhole_0ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
BaptisteFoy
force-pushed
the
baptiste.foy/FA/promote-scripts-on-main
branch
from
0a0407c to
3dd1ba8
Compare
…m on success on main
BaptisteFoy
force-pushed
the
baptiste.foy/FA/promote-scripts-on-main
branch
from
3dd1ba8 to
69dc8a9
Compare
chouquette
approved these changes
Dec 12, 2024
| @@ -0,0 +1,15 @@ | |||
| qa_installer_script_main: | |||
| image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES | |||
There was a problem hiding this comment.
pinging @chouetz since he's in the process of using per-images variables, this will need to be updated in his PR
There was a problem hiding this comment.
LGTM, I will have to re-run my script, thanks for checking this
chouetz
approved these changes
Dec 12, 2024
|
/merge |
Devflow running:
|
dd-mergequeue
bot
deleted the
baptiste.foy/FA/promote-scripts-on-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new job to "promote" the installer install scripts on
mainif they pass E2E tests. That way internal customers of script flavors will be able to test them on their infrastructure before merging.Deployed url: https://installtesting.datad0g.com/scripts/install-databricks.sh
Describe how you validated your changes
Changed the trigger to use this branch and checked on the target bucket
Possible Drawbacks / Trade-offs
Additional Notes