Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SpanNameAsResourceName from default OTel agent config #32112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IbraheemA
Copy link
Contributor

@IbraheemA IbraheemA commented Dec 12, 2024

What does this PR do?

Since enable_operation_and_resource_name_logic_v2 is now enabled by default in OTel agent, disable SpanNameAsResourceName

JIRA Link: https://datadoghq.atlassian.net/browse/OTEL-2308

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@IbraheemA IbraheemA requested a review from dineshg13 December 12, 2024 19:07
@IbraheemA IbraheemA requested a review from a team as a code owner December 12, 2024 19:07
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/opentelemetry OpenTelemetry team labels Dec 12, 2024
@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 8a450cc476d33f6374164f1f00d92cdf65309558

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -0.02MB 1271.24MB 1271.25MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ⚠️ 526.44MB 526.44MB 70.00MB
datadog-agent-x86_64-rpm -0.01MB 1280.47MB 1280.49MB 140.00MB
datadog-agent-x86_64-suse -0.01MB 1280.47MB 1280.49MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.27MB 113.27MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.27MB 113.27MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.02MB ⚠️ 1005.43MB 1005.41MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.70MB 108.70MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 1014.64MB 1014.62MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.77MB 108.77MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51000292 --os-family=ubuntu

Note: This applies to commit 6291c2f

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ae8d43b9-93fb-4750-85f0-b1a9c892acab

Baseline: 8a450cc
Comparison: 6291c2f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.22 [+1.48, +2.95] 1 Logs
quality_gate_idle_all_features memory utilization +0.88 [+0.76, +0.99] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.64 [-0.15, +1.43] 1 Logs
file_tree memory utilization +0.40 [+0.28, +0.53] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.40 [-0.07, +0.86] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.13 [-0.64, +0.91] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.91, +0.94] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.70, +0.71] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.85, +0.85] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.09] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.66, +0.60] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.89, +0.80] 1 Logs
quality_gate_idle memory utilization -0.29 [-0.33, -0.24] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.33 [-3.28, +2.61] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.61 [-0.68, -0.54] 1 Logs
otel_to_otel_logs ingress throughput -1.14 [-1.83, -0.45] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant