Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: arm64 binaries #264

Closed
mcuelenaere opened this issue Jun 22, 2023 · 11 comments
Closed

Feature request: arm64 binaries #264

mcuelenaere opened this issue Jun 22, 2023 · 11 comments

Comments

@mcuelenaere
Copy link

opentracing-contrib/nginx-opentracing#391 seems to have linux/arm64 images, but AFAICS dd-opentracing-cpp does not provide arm64 builds. Is this on purpose or just an oversight? Would it be possible to provide arm64 binaries?

@dgoffredo
Copy link
Contributor

dd-opentracing-cpp does not provide ARM64 binaries because the need has not yet arose, and because I do not have access to an ARM64 machine. Also, the CI system we use, CircleCI, does not support ARM64 beneath their docker executor (we'd have to switch to using VMs).

What's your use case? I can probably add this to our feature request pipeline. I see you opened a similar issue in our nginx module repo.

@mcuelenaere
Copy link
Author

Our usecase is that we are evaluating switching to AWS Graviton processors and atm this means we need to disable APM tracing for our nginx setup.

I see that https://circleci.com/docs/using-arm/ exists, but I'm not super familiar with CircleCI. Could QEMU work instead? I believe that's what Github Actions uses by default.

@dgoffredo
Copy link
Contributor

Please submit this request as a support issue via https://help.datadoghq.com/hc/en-us/requests/new and reference these github issues. This way, the feature request is associated with your account and can be tracked internally.

I see that https://circleci.com/docs/using-arm/ exists, but I'm not super familiar with CircleCI. Could QEMU work instead? I believe that's what Github Actions uses by default.

Our CI runs on CircleCI's built-in Docker executor. We could switch to using a "VM executor," but that might involve a rewrite of our CI configuration. Not a deal-breaker, but potentially time-consuming.

@mcuelenaere
Copy link
Author

Issue filed!

@dgoffredo
Copy link
Contributor

Thanks, let's leave this open, and I'll chase after whoever I need to internally.

@bwhaley
Copy link

bwhaley commented Jul 25, 2024

Hi folks, any updates on this one? We'd also like to use Arm. Fwiw, CircleCI supports Arm for Docker executors now. See: https://circleci.com/docs/using-docker/#arm

@dgoffredo
Copy link
Contributor

The non-OpenTracing version of the Datadog tracing nginx module, nginx-datadog, has supported arm64 for a while. It's configured differently, but has feature parity. If you can afford to change all of your tracing configuration, migrating is an option.

@bwhaley
Copy link

bwhaley commented Jul 30, 2024

Unfortunately that won't work in our case because it isn't compatible with openresty (DataDog/nginx-datadog#30).

Any chance of adding Arm to the build process in this repo?

@dgoffredo
Copy link
Contributor

Bummer. I'm no longer a maintainer of this repo, so I can't comment on its priority.

@dmehala for visibility.

@bwhaley
Copy link

bwhaley commented Jul 30, 2024

Gotcha, well in that case, special thanks for your feedback anyway.

@dmehala
Copy link

dmehala commented Jul 30, 2024

Hi @bwhaley

dd-opentracing-cpp is deprecated. There will be no further work on this library. Best outcome is to require OpenResty support here for visibility.

@dmehala dmehala closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants