Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise span error in gin middleware #2815

Open
theo303 opened this issue Aug 9, 2024 · 1 comment
Open

More precise span error in gin middleware #2815

theo303 opened this issue Aug 9, 2024 · 1 comment
Labels
apm:ecosystem contrib/* related feature requests or bugs

Comments

@theo303
Copy link

theo303 commented Aug 9, 2024

Hello !
First of all, excuse me if I'm using the wrong tool/place to ask a question, I'm not used to this.

I'm wondering if I can improve how errors are displayed in datadog for my http requests (I'm using gin). Now I have this:
image
I would like ideally to have a full go error displayed here.

I guess it's the default behavior because the gin middleware calls FinishRequestSpan(). Since this function is deferred after all handlers have finished, it will override the error in the span if I try to set it before ?

Is this the desired behavior ?
Should I make my own middleware and stop using the one in contrib/gin-gonic ?

Thanks !

@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Aug 9, 2024
@darccio
Copy link
Member

darccio commented Aug 9, 2024

@theo303 Thanks for reaching out! This is something we've found in other contribs. Allow us to review it internally and we'll come back to you.

@darccio darccio added apm:ecosystem contrib/* related feature requests or bugs and removed needs-triage New issues that have not yet been triaged labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

No branches or pull requests

2 participants