Allow goroutines not launched by the tracer to stop on tracer.Stop() #3025
+43
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a new package,
contribroutines
, which contains astop
channel and an API for getting the channel and closing the channel.The contribs should get the channel to use as a stop condition for any goroutines they launch, and the tracer should be the only one to stop the channel.
Motivation
We needed a way for the tracer to stop any goroutines that it does not directly manage on tracer.Stop(); without this mechanism, we were dealing with runaway goroutines.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!