Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-2334 Run Dynamic Instrumentation system tests #4146

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Nov 22, 2024

What does this PR do?
Adds the Dynamic Instrumentation system tests to the list of tests in system tests workflow.

Motivation:
Initial DI implementation in Ruby.

Change log entry
None

Additional Notes:

This PR goes with DataDog/system-tests#3531 which enables the tests from the system tests' side.

How to test the change?

This PR previously executed against the branch in DataDog/system-tests#3531 which ran the added tests.

@github-actions github-actions bot added the core Involves Datadog core libraries label Nov 22, 2024
lib/datadog/di/code_tracker.rb Outdated Show resolved Hide resolved
spec/datadog/di/spec_helper.rb Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024

Benchmarks

Benchmark execution time: 2024-11-25 18:16:18

Comparing candidate commit d7fe87c in PR branch di-st-enable with baseline commit 23a33f9 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.576op/s; -0.566op/s] or [-8.714%; -8.570%]

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (23a33f9) to head (d7fe87c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4146      +/-   ##
==========================================
- Coverage   97.78%   97.78%   -0.01%     
==========================================
  Files        1353     1353              
  Lines       81786    81785       -1     
  Branches     4141     4141              
==========================================
- Hits        79974    79971       -3     
- Misses       1812     1814       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@p-datadog p-datadog force-pushed the di-st-enable branch 6 times, most recently from 99701d4 to 42881c6 Compare November 25, 2024 00:38
@p-datadog p-datadog marked this pull request as ready for review November 25, 2024 17:35
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Nov 25, 2024
@p-datadog p-datadog requested a review from a team as a code owner November 25, 2024 17:35
@p-datadog p-datadog changed the title Run DI system tests DEBUG-2334 Run Dynamic Instrumentation system tests Nov 25, 2024
@p-datadog p-datadog merged commit 77b9d8f into master Nov 26, 2024
290 checks passed
@p-datadog p-datadog deleted the di-st-enable branch November 26, 2024 06:35
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants