DDA w/operator component cleanups and improvements #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pducolin
approved these changes
Nov 19, 2024
fanny-jiang
force-pushed
the
fanny/operator-namespaces
branch
from
676da02 to
8355c2d
Compare
pducolin
approved these changes
Nov 22, 2024
pducolin
reviewed
Nov 22, 2024
| @@ -11,7 +11,7 @@ import ( | |||
| ) | |||
|
|
|||
| // OperatorOutput is used to import the Operator component | |||
| type OperatorOutput struct { | |||
| type OperatorOutput struct { // nolint:revive, We want to keep the name as <Component>Output | |||
There was a problem hiding this comment.
I was getting this lint error:
Error: components/datadog/operator/component.go:11:6: exported: type name will be used as operator.OperatorOutput by other packages, and that stutters; consider calling this Output (revive)
type OperatorOutput struct {
pducolin
approved these changes
Dec 10, 2024
| type OperatorOutput struct { // nolint:revive, We want to keep the name as <Component>Output | ||
| components.JSONImporter | ||
|
|
||
| Operator compkubernetes.KubernetesObjRefOutput `pulumi:"operator"` |
There was a problem hiding this comment.
Should use json decorator on outputs
💬 suggestion
Suggested change
| Operator compkubernetes.KubernetesObjRefOutput `pulumi:"operator"` | |
| Operator compkubernetes.KubernetesObjRefOutput `json:"operator"` |
| @@ -18,7 +18,7 @@ type KubernetesObjRefOutput struct { | |||
| LabelSelectors map[string]string `json:"labelSelectors"` | |||
| } | |||
|
|
|||
| type KubernetesObjectRef struct { | |||
| type KubernetesObjectRef struct { // nolint:revive, We want to keep the name as <Component>Output | |||
There was a problem hiding this comment.
❓ question
What is revive complaining about here? The comment seems to be a copy paste from above that does not fit here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
namespaceand operator image path inagentwithoperatorparamsandoperatorparamsKubernetesObjectRefto the kubernetes componentKubernetesObjectRefto the operator component outputWhich scenarios this will impact?
Motivation
Additional Notes