-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDA w/operator component cleanups and improvements #1251
Open
fanny-jiang
wants to merge
14
commits into
main
Choose a base branch
from
fanny/operator-namespaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
135ae7a
fix namespaces in DDA w/operator components
fanny-jiang 75195b0
apply review suggestions, refactor
fanny-jiang 048ebb2
Merge branch 'main' into fanny/operator-namespaces
fanny-jiang 8355c2d
nolint
fanny-jiang 29112d3
add more params
fanny-jiang 23a0e28
add logs_dd_url var for fakeintake
fanny-jiang e6f51b9
Merge branch 'main' into fanny/operator-namespaces
fanny-jiang ea0d6a1
cleanup
fanny-jiang c94aeef
more refactor
fanny-jiang 2dfb561
fix labelselector
fanny-jiang a5d2ffc
Merge branch 'main' into fanny/operator-namespaces
fanny-jiang 1ab12b1
fix dda kindvm
fanny-jiang c83c5b7
fix default namespace
fanny-jiang 156e590
fix linter
fanny-jiang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ import ( | |
"github.com/DataDog/test-infra-definitions/components" | ||
) | ||
|
||
type KubernetesObjRefOutput struct { | ||
type KubernetesObjRefOutput struct { // nolint:revive, We want to keep the name as <Component>Output | ||
components.JSONImporter | ||
|
||
Namespace string `json:"namespace"` | ||
|
@@ -18,7 +18,7 @@ type KubernetesObjRefOutput struct { | |
LabelSelectors map[string]string `json:"labelSelectors"` | ||
} | ||
|
||
type KubernetesObjectRef struct { | ||
type KubernetesObjectRef struct { // nolint:revive, We want to keep the name as <Component>Output | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ question |
||
pulumi.ResourceState | ||
components.Component | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the lint error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting this lint error: